[RELEASE] 4.8.2 - #4903
Conversation
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
|
Moving to QA |
(1) [FIXED]
Current: When target location is submitted, the app crashes Expected: no crash Xiaomi Redmi 13, Android 15
|
|
(1) should be fixed in the commit 8d78aaf |
(2) [FIXED]Snackbar notifications overlaps the bottom bar. That seems to be related with infinite edges Xiaomi Redmi 13, Android 15 |
DeepDiver1975
left a comment
There was a problem hiding this comment.
Release review for 4.8.2 (maintainer triage, non-blocking — release PRs are owned by the release manager).
Version bump — consistent: versionCode 48000100 → 48000200 and versionName "4.8.1" → "4.8.2" in owncloudApp/build.gradle. Monotonic and matches the tag.
Changelog — well-formed (calens convention):
- TOC entry, section header, and intro line all updated unreleased → 4.8.2 (2026-06-30).
- Compare link correctly rewritten to
v4.8.1...v4.8.2. - Three fragments moved
changelog/unreleased/→changelog/4.8.2_2026-06-30/(4887 Bugfix: Infinite edges, 4897 Security: Redact cookie headers in logs, 4901 Bugfix: Remove useless debug manifest file) — each follows TEMPLATE (Type: Summary / blank / body / blank / URLs). - Generated
CHANGELOG.mdSummary + Details sections match the fragments. Generate Changelog check passes.
Code change — the fix: use content layout to show snackbar with action commit (drops the layoutId param across ActivityExt.kt, FileActivity.java, FileDisplayActivity.kt, always using android.R.id.content) is the QA-stabilization fix for the move/copy crash (report #1 in the PR body, marked FIXED). Folding a regression fix into the release branch during QA is fine. Minor note: it has no dedicated changelog fragment, but it's an in-cycle fix on top of the already-listed edge-to-edge feature (#4887), so no separate entry is required.
All CI green (Detekt, unit + instrumented data tests, CodeQL, validations) and already approved by @jesmrec. No stray/unrelated code. Looks good to ship from a maintainer standpoint.
Note: QA report #2 (snackbars overlapping bottom bar) is still unchecked in the PR description — leaving the merge decision to the release manager.
|
(2) should be fixed in the commit 600f558 |
|
about (2) is fixed. Just found that most of the snackbars rose from the bottom of the screen, but others like the snackbar notifying the absence of the local file when clicking on a cell on the uploads file, show the snackbar from the bottom view. We should think about the way to unify how to show them. Not a blocker for 4.8.2 |
(3) [FIXED]
Current: snackbar appears so far from the bottom bar: Screenrecorder-2026-06-29-14-11-25-583.mp4Expected: snackbar in same position than other snackbars Note: it could affect to other av. offline previews Xiaomi Redmi 13, Android 15 |
6f7a6f2 to
cdf73c8
Compare
|
(3) should be fixed in the commit cdf73c8 Now, snackbars are attached to the bottom bar only when necessary, on screens that include a bottom navigation bar (Personal, Shares, Spaces, Uploads and Av. Offline) |
(4) [FIXED]
Current: snackbar Xiaomi Redmi 13, Android 15 |
|
(4) was caused by changes in commit cdf73c8 I've reset the commit and undone change in |
(5) [FIXED]In the tab (landscape orientation), the snackbar collapses with the tablet bar: Screen_Recording_20260630_134115_ownCloud.mp4Reproducible in the spaces operations, and also in the Samsung Galaxy Tab A8, Android 14 |
7a2b047 to
e4d4b6f
Compare
|
(5) should be fixed in commit e4d4b6f |
(6) [FIXED]
Current: snackbar is shown like in report (3), so far from the bottom, because there is no bottom bar Expected: snackbar close to the bottom Xiaomi Redmi 13, Android 15 |
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Co-authored-by: owncloud-calens-bot[bot] <276982735+owncloud-calens-bot[bot]@users.noreply.github.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Commits Update(1) should be fixed in commit 1c741ed (the same solution as before: use layout content for snackbars with actions) New fix found for the reports: (2), (3), (4), (5), (6). They should be fixed in commit 5eadeed(solution: snackbars are attached to the bottom navigation bar only when it's visible) |
|
Everything fixed 🚀 |
DeepDiver1975
left a comment
There was a problem hiding this comment.
LGTM. Coherent 4.8.2 release PR; cross-checked against release/4.8.2:
- Version bump consistent:
owncloudApp/build.gradle:104-105versionCode 48000100 → 48000200,versionName "4.8.1" → "4.8.2". - Changelog consistent:
CHANGELOG.mdheader/date[4.8.2] (2026-07-01), compare linkv4.8.1...v4.8.2; three fragments moved tochangelog/4.8.2_2026-07-01/(4887, 4897, 4901),changelog/unreleased/now empty. Details section matches the fragment bodies. - All required checks green (unit + instrumented tests, Detekt, CodeQL, changelog gen, semantic-commit).
One non-blocking observation on the snackbar fix: the anchor-view logic was added to Activity.showMessageInSnackbar, Activity.showSnackbarWithAction, Fragment.showMessageInSnackbar, and BaseActivity.showSnackMessage, but not to Fragment.showSnackbarWithAction (FragmentExt.kt:61-71) — it still calls Snackbar.make(...).setAction(...).show() with no setAnchorView. Its only caller (FileDetailsFragment) uses LENGTH_LONG, so if that path can show over the bottom bar it'd overlap. Worth confirming it was intentionally left out.
🤖 Generated with Claude Code
Related Issues
App: #4890
QA
#4890 (comment)
Reports: