Skip to content

[RELEASE] 4.8.2 - #4903

Merged
joragua merged 5 commits into
masterfrom
release/4.8.2
Jul 1, 2026
Merged

[RELEASE] 4.8.2#4903
joragua merged 5 commits into
masterfrom
release/4.8.2

Conversation

@joragua

@joragua joragua commented Jun 26, 2026

Copy link
Copy Markdown
Member

Related Issues

App: #4890


QA

#4890 (comment)

Reports:

@joragua joragua self-assigned this Jun 26, 2026
@joragua joragua linked an issue Jun 26, 2026 that may be closed by this pull request
24 tasks
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua marked this pull request as ready for review June 26, 2026 08:50
@joragua
joragua requested a review from jesmrec June 26, 2026 08:50

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@jesmrec

jesmrec commented Jun 26, 2026

Copy link
Copy Markdown
Member

Moving to QA

@jesmrec jesmrec changed the title build: update versionCode and versionName for 4.8.2 [RELEASE] 4.8.2 Jun 26, 2026
@jesmrec

jesmrec commented Jun 26, 2026

Copy link
Copy Markdown
Member

(1) [FIXED]

  1. Select to copy or move a file

Current: When target location is submitted, the app crashes

Expected: no crash

Xiaomi Redmi 13, Android 15
Pixel 7, Android 16
Samsung Galaxy Tab A8, Android 14

04dc853ff

@joragua

joragua commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

(1) should be fixed in the commit 8d78aaf

@jesmrec

jesmrec commented Jun 26, 2026

Copy link
Copy Markdown
Member

(2) [FIXED]

Snackbar notifications overlaps the bottom bar. That seems to be related with infinite edges

Xiaomi Redmi 13, Android 15
Pixel 7, Android 16
8d78aaf028

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release review for 4.8.2 (maintainer triage, non-blocking — release PRs are owned by the release manager).

Version bump — consistent: versionCode 48000100 → 48000200 and versionName "4.8.1" → "4.8.2" in owncloudApp/build.gradle. Monotonic and matches the tag.

Changelog — well-formed (calens convention):

  • TOC entry, section header, and intro line all updated unreleased → 4.8.2 (2026-06-30).
  • Compare link correctly rewritten to v4.8.1...v4.8.2.
  • Three fragments moved changelog/unreleased/changelog/4.8.2_2026-06-30/ (4887 Bugfix: Infinite edges, 4897 Security: Redact cookie headers in logs, 4901 Bugfix: Remove useless debug manifest file) — each follows TEMPLATE (Type: Summary / blank / body / blank / URLs).
  • Generated CHANGELOG.md Summary + Details sections match the fragments. Generate Changelog check passes.

Code change — the fix: use content layout to show snackbar with action commit (drops the layoutId param across ActivityExt.kt, FileActivity.java, FileDisplayActivity.kt, always using android.R.id.content) is the QA-stabilization fix for the move/copy crash (report #1 in the PR body, marked FIXED). Folding a regression fix into the release branch during QA is fine. Minor note: it has no dedicated changelog fragment, but it's an in-cycle fix on top of the already-listed edge-to-edge feature (#4887), so no separate entry is required.

All CI green (Detekt, unit + instrumented data tests, CodeQL, validations) and already approved by @jesmrec. No stray/unrelated code. Looks good to ship from a maintainer standpoint.

Note: QA report #2 (snackbars overlapping bottom bar) is still unchecked in the PR description — leaving the merge decision to the release manager.

@joragua

joragua commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

(2) should be fixed in the commit 600f558

@jesmrec

jesmrec commented Jun 29, 2026

Copy link
Copy Markdown
Member

about (2) is fixed. Just found that most of the snackbars rose from the bottom of the screen, but others like the snackbar notifying the absence of the local file when clicking on a cell on the uploads file, show the snackbar from the bottom view. We should think about the way to unify how to show them. Not a blocker for 4.8.2

@jesmrec

jesmrec commented Jun 29, 2026

Copy link
Copy Markdown
Member

(3) [FIXED]

  1. Create a txt file
  2. Set the file as av. offline
  3. In the web (or any other client), modify the txt file
  4. In the Android client, open the txt file

Current: snackbar appears so far from the bottom bar:

Screenrecorder-2026-06-29-14-11-25-583.mp4

Expected: snackbar in same position than other snackbars

Note: it could affect to other av. offline previews

Xiaomi Redmi 13, Android 15
600f558b3c

@joragua
joragua force-pushed the release/4.8.2 branch 2 times, most recently from 6f7a6f2 to cdf73c8 Compare June 30, 2026 09:50
@joragua

joragua commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

(3) should be fixed in the commit cdf73c8

Now, snackbars are attached to the bottom bar only when necessary, on screens that include a bottom navigation bar (Personal, Shares, Spaces, Uploads and Av. Offline)

@jesmrec

jesmrec commented Jun 30, 2026

Copy link
Copy Markdown
Member

(4) [FIXED]

  1. In the list of files, click on the three-dot-button of any non-downloaded file
  2. Click on Download

Current: snackbar Download enqueued overlapping the bottom bar
Expected: snackbar Download enqueued over the bottom bar

Xiaomi Redmi 13, Android 15
Pixel 7, Android 16
cdf73c8ec6

@joragua

joragua commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

(4) was caused by changes in commit cdf73c8

I've reset the commit and undone change in FileDisplay.kt:1427 and it should be fixed now 🙌🏻

@jesmrec

jesmrec commented Jun 30, 2026

Copy link
Copy Markdown
Member

(5) [FIXED]

In the tab (landscape orientation), the snackbar collapses with the tablet bar:

Screen_Recording_20260630_134115_ownCloud.mp4

Reproducible in the spaces operations, and also in the Details view when syncing and av. offline.

Samsung Galaxy Tab A8, Android 14
86881ddab

@joragua
joragua force-pushed the release/4.8.2 branch 2 times, most recently from 7a2b047 to e4d4b6f Compare June 30, 2026 15:15
@joragua

joragua commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

(5) should be fixed in commit e4d4b6f

@jesmrec

jesmrec commented Jun 30, 2026

Copy link
Copy Markdown
Member

(6) [FIXED]

  1. Long press over any file to open multiselection
  2. Select several items
  3. Click on download/sync icon, on the top bar

Current: snackbar is shown like in report (3), so far from the bottom, because there is no bottom bar

Expected: snackbar close to the bottom

Xiaomi Redmi 13, Android 15
Pixel 7, Android 16
Samsung Tab A8, Android 14
e4d4b6fb

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
owncloud-calens-bot Bot and others added 2 commits July 1, 2026 10:05
Co-authored-by: owncloud-calens-bot[bot] <276982735+owncloud-calens-bot[bot]@users.noreply.github.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua

joragua commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Commits Update

(1) should be fixed in commit 1c741ed (the same solution as before: use layout content for snackbars with actions)

New fix found for the reports: (2), (3), (4), (5), (6). They should be fixed in commit 5eadeed(solution: snackbars are attached to the bottom navigation bar only when it's visible)

@jesmrec

jesmrec commented Jul 1, 2026

Copy link
Copy Markdown
Member

Everything fixed 🚀

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Coherent 4.8.2 release PR; cross-checked against release/4.8.2:

  • Version bump consistent: owncloudApp/build.gradle:104-105 versionCode 48000100 → 48000200, versionName "4.8.1" → "4.8.2".
  • Changelog consistent: CHANGELOG.md header/date [4.8.2] (2026-07-01), compare link v4.8.1...v4.8.2; three fragments moved to changelog/4.8.2_2026-07-01/ (4887, 4897, 4901), changelog/unreleased/ now empty. Details section matches the fragment bodies.
  • All required checks green (unit + instrumented tests, Detekt, CodeQL, changelog gen, semantic-commit).

One non-blocking observation on the snackbar fix: the anchor-view logic was added to Activity.showMessageInSnackbar, Activity.showSnackbarWithAction, Fragment.showMessageInSnackbar, and BaseActivity.showSnackMessage, but not to Fragment.showSnackbarWithAction (FragmentExt.kt:61-71) — it still calls Snackbar.make(...).setAction(...).show() with no setAnchorView. Its only caller (FileDetailsFragment) uses LENGTH_LONG, so if that path can show over the bottom bar it'd overlap. Worth confirming it was intentionally left out.

🤖 Generated with Claude Code

@joragua
joragua merged commit 90f1483 into master Jul 1, 2026
13 checks passed
@joragua
joragua deleted the release/4.8.2 branch July 1, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RELEASE] 4.8.2

3 participants