Skip to content

perf(formatter): use SmallVec for MemberChain collections#23776

Merged
leaysgur merged 2 commits into
oxc-project:mainfrom
mds-ant:perf/formatter-member-chain-smallvec
Jul 8, 2026
Merged

perf(formatter): use SmallVec for MemberChain collections#23776
leaysgur merged 2 commits into
oxc-project:mainfrom
mds-ant:perf/formatter-member-chain-smallvec

Conversation

@mds-ant

@mds-ant mds-ant commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What

MemberChain::from_call_expression runs for every call expression in the file and allocates 3+ heap collections per chain: the initial member list, the VecDeque<MemberChainGroup> in the builder/tail, and a Vec<ChainMember> per group.

Change

Replace these with SmallVec<[_; 4]>. ChainMember is two pointers plus a one-byte enum, and chains/groups are typically 2–6 elements, so a 4-element inline buffer keeps the common case on the stack.

VecDeque was only used for one pop_front in maybe_merge_with_first_group. This feels a little heavy-handed; SmallVec::remove(0) over ≤4 groups is fine.

FormatMemberChainGroup gains a separate reference lifetime: SmallVec<[T; N]> (smallvec 1.x) is invariant over T, and the previous code relied on MemberChainGroup being covariant over 'b to unify the borrow lifetime with the inner 'b.

File Before After Delta
pdf.mjs 15,308 4,655 −10,653 (−69.6%)
App.tsx 7,588 2,933 −4,655 (−61.3%)
antd.js 83,239 36,634 −46,605 (−56.0%)
kitchen-sink.tsx 20,458 10,986 −9,472 (−46.3%)
binder.ts 824 490 −334 (−40.5%)
checker.ts 18,642 11,947 −6,695 (−35.9%)
RadixUIAdoptionSection.jsx 54 54 ±0 (0.0%)

Some performance numbers from perf stat -e instructions (median of 5 runs, release build):

File Before After Delta
pdf.mjs 204,603,800 202,990,088 −1,613,712 (−0.79%)
App.tsx 110,011,608 109,345,945 −665,663 (−0.60%)
antd.js 1,607,371,443 1,600,715,018 −6,656,425 (−0.41%)

Verification

  • cargo clippy -p oxc_formatter (+--features detect_code_removal) — clean
  • cargo test -p oxc_formatter --test mod — 294 passed
  • cargo run -p oxc_prettier_conformance — snapshots unchanged
  • cargo allocs — snapshot updated

This PR was assisted by Claude Code.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing mds-ant:perf/formatter-member-chain-smallvec (acef583) with main (6371fed)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the A-formatter Area - Formatter label Jun 25, 2026
`MemberChain::from_call_expression` runs for every call expression and
allocated three+ heap collections per chain: the initial member list, the
`VecDeque<MemberChainGroup>` in the builder/tail, and a `Vec<ChainMember>` per
group. Chains and groups are typically 2-6 elements (`ChainMember` is two
pointers + a one-byte enum), so a 4-element `SmallVec` keeps the common case
on the stack.

`VecDeque` was only used for one `pop_front` in `maybe_merge_with_first_group`;
`SmallVec::remove(0)` over <=4 groups is fine.

`FormatMemberChainGroup` gains a separate reference lifetime because
`SmallVec<[T; N]>` (smallvec 1.x) is invariant over `T`, and the previous code
relied on `MemberChainGroup` being covariant over `'b` to unify the borrow
lifetime with the inner `'b`.

`cargo allocs` formatter sys-alloc counts:

| File             |  before |   after |        |
| ---------------- | ------: | ------: | -----: |
| antd.js          |  83,239 |  36,634 | -56.0% |
| App.tsx          |   7,588 |   2,933 | -61.3% |
| pdf.mjs          |  15,308 |   4,655 | -69.6% |
| checker.ts       |  18,642 |  11,947 | -35.9% |

Wall-clock effect is within criterion noise (allocator is ~1% of cycles); peak
RSS unchanged (these are short-lived temporaries that recycle in tcache).
@mds-ant mds-ant force-pushed the perf/formatter-member-chain-smallvec branch from 8cc8035 to c455feb Compare July 7, 2026 10:07

@leaysgur leaysgur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.
Thank you!

Comment thread crates/oxc_formatter/src/utils/member_chain/groups.rs
Signed-off-by: Yuji Sugiura <6259812+leaysgur@users.noreply.github.com>
@leaysgur leaysgur merged commit a2f255b into oxc-project:main Jul 8, 2026
36 checks passed
Boshen added a commit that referenced this pull request Jul 14, 2026
# Oxlint
### 🚀 Features

- 0433a83 linter/eslint/no-inner-declarations: Add `namespaces` option
(#24044) (Boshen)
- 92f154a oxlint,oxfmt: Auto-discover `.mts` config files (#24357)
(camc314)
- 8c1d74b linter/import/no-duplicates: Add autofix logic (#24273) (Cole
Ellison)

### 🐛 Bug Fixes

- 0b086de linter/jest/prefer-lowercase-title: False positive when
`lowercaseFirstCharacterOnly` is false (#24414) (Connor Shea)
- 097cb95 linter: Allow `vite-plus/test` and `@effect as Vitest source
(#24196) (Liang)
- 8337835 linter: Error on `ignorePatterns` that cannot match files
aoutside the config directory (#24341) (leaysgur)
- 9ba30e5 linter/oxc/bad-replace-all-arg: Add note to enhance diagnostic
(#24346) (camc314)
- 2ce5a33 linter: Resolve `ignorePatterns` relative to the config dir
(#24339) (leaysgur)
- ab90eed linter/eslint/no-loop-func: Do not error on catch variables
(#24316) (Chris Opperwall)
- b67f0a6 linter/eslint/no-unused-vars: Count default parameter updates
as usage (#24323) (camc314)
- d193f8e linter: Detect Junie agent env vars (#24277) (Jeevan Mohan
Pawar)
- 2aecf60 linter/eslint/no-unreachable: Handle `break` in switch stmts
correctly (#24260) (camc314)

### ⚡ Performance

- 7f80cac linter/vue/prop-name-casing: Precompile `ignoreProps` regex
pattern (#24413) (connorshea)
- 6272051 linter/typescript/no-require-imports: Compile allow patterns
once (#24417) (connorshea)
- fb1edf1 linter: Compute comment fix span only for directive comments
(#24419) (connorshea)
- 33805b9 linter/jsdoc/require-param: Compile checkTypesPattern regex
once (#24420) (connorshea)
- 8de6fca linter/jest/valid-title: Compile disallowedWords regex once
(#24412) (Connor Shea)
- 4a0d8dc linter/eslint/no-underscore-dangle: Avoid String clone per
identifier (#24371) (Ian Macalinao)
- f3ab04c linter/typescript/consistent-type-imports: Remove redundant
Vec per violation (#24370) (Ian Macalinao)
- 4d2d78d linter/typescript/prefer-ts-expect-error: Avoid String clone
per comment (#24369) (Ian Macalinao)
# Oxfmt
### 🚀 Features

- 3a7fe74 formatter_css: Update oxc-css-parser to 0.0.7 (#24434)
(leaysgur)
- 0173cd3 formatter_css: Format Less :extend and merge props (#24358)
(leaysgur)
- 92f154a oxlint,oxfmt: Auto-discover `.mts` config files (#24357)
(camc314)
- df250df formatter: Support `quoteProps` for TS enum and methods
(#24309) (leaysgur)
- a9a5cd6 formatter_core: Expose `SourceText::as_str()` (#24281)
(leaysgur)

### 🐛 Bug Fixes

- 162bddf formatter: Add required parens for conditional type in type
parameter constraint (#24450) (leaysgur)
- 2d22a91 formatter: Determine type cast target from span instead of
lexical scan (#24447) (leaysgur)
- 25306e9 formatter: Do not add extra parens with type cast comment
(#24444) (leaysgur)
- bd6edfe formatter: Break arrow signature that exactly fills the line
when cond body may hug (#24440) (leaysgur)
- a99ef41 formatter: Keep quotes on method signature named new (#24432)
(leaysgur)
- fcc28df formatter_css: Keep glued-braket-value tight (#24352)
(leaysgur)
- 8337835 linter: Error on `ignorePatterns` that cannot match files
aoutside the config directory (#24341) (leaysgur)
- b7c7e15 formatter: Add parens for import and private field in new
callee chain (#24320) (leaysgur)
- 0c8f6e4 formatter: Update detect_code_removal for #24309 (#24314)
(leaysgur)
- a85aad0 formatter: Fix member-chain and non-null parens (#24312)
(leaysgur)
- 1c29c73 formatter: Preserve `TSNonNullExpression` in chain expression
(#24311) (leaysgur)
- 8933c0e formatter: Keep comment inside of empty `switch` block
(#24308) (leaysgur)
- ec26af2 formatter: Preserve blank lines between JSX attrs (#24290)
(leaysgur)
- 70bd54d formatter: Keep arrow function body comment (#24287)
(leaysgur)
- 415fe1e oxfmt: Error on ignorePatterns that cannot match files outside
the config directory (#24286) (leaysgur)
- eeabc4a formatter_css: Bail on EOF-recovered parse errors (#24282)
(leaysgur)
- 42ec8de formatter: Keep comments inside surviving parens and
suppressed statement terminators (#24253) (leaysgur)
- 1343779 formatter: Keep comment inline for empty statements (#24249)
(leaysgur)
- b996579 formatter: Print ; before trailing comments part 2 (#24246)
(leaysgur)
- 4f86e8c formatter: Print `;` before trailing comments (#24244)
(leaysgur)
- 01252e4 formatter: Add or remove parens for `let` declaration (#24215)
(leaysgur)

### ⚡ Performance

- eeb1913 formatter_core: Avoid per-call `Vec` work-stack in soft-line
removal (#23775) (Marius Schulz)
- a2f255b formatter: Use `SmallVec` for `MemberChain` collections
(#23776) (Marius Schulz)

### 📚 Documentation

- b52d0f5 formatter: Add TODO comment about unsound code (#24372)
(overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants