fix(linter): resolve `ignorePatterns` relative to the config dir by leaysgur · Pull Request #24339 · oxc-project/oxc

leaysgur · 2026-07-10T04:28:20Z

Root config's ignorePatterns are now resolved relative to the directory containing the config file, instead of CWD.

Also fixes a latent issue: a --config <path> containing .. silently disabled all ignorePatterns (the unnormalized parent dir never prefix-matches lint target paths). Explicit config paths are now lexically normalized, same as Oxfmt.

Behavior change

The new anchoring applies in all cases, including --config / LSP configPath. This intentionally differs from ESLint, which resolves alternate-config ignore patterns relative to CWD:

extends, overrides[].files, and JS plugin specifiers are already config-file-relative, including via --config
- rooting only ignorePatterns at CWD would give one file two coordinate systems
Wrappers like Vite+ pass --config <workspace-root config> as an implementation detail while CWD stays at the invocation directory, so "--config means CWD-relative" does not hold in practice
- oxlint,oxfmt: ignorePatterns isn't relative to configuration file with --config #24276

Impact should be small: bare names (dist, *.min.js) and **/-prefixed patterns are unaffected by the anchor.

The updated config_ignore_patterns/with_oxlintrc snapshot shows the --config case.

leaysgur · 2026-07-10T04:28:35Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-07-10T04:36:19Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks¹

_{Comparing 07-09-fix_oxlint_resolve_ignorepatterns_relative_to_the_config_dir (9954da7) with main (a3a39f9)}

66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314

thanks!

camc314 · 2026-07-10T08:34:02Z

Merge activity

Jul 10, 8:34 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 10, 8:34 AM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 10, 8:45 AM UTC: Merged by the Graphite merge queue.

) Fixes #24310 Root config's `ignorePatterns` are now resolved relative to the directory containing the config file, instead of CWD. Also fixes a latent issue: a `--config <path>` containing `..` silently disabled all `ignorePatterns` (the unnormalized parent dir never prefix-matches lint target paths). Explicit config paths are now lexically normalized, same as Oxfmt. ### Behavior change The new anchoring applies in all cases, including `--config` / LSP `configPath`. This intentionally differs from ESLint, which resolves alternate-config ignore patterns relative to CWD: - `extends`, `overrides[].files`, and JS plugin specifiers are already config-file-relative, including via `--config` - rooting only `ignorePatterns` at CWD would give one file two coordinate systems - Wrappers like Vite+ pass `--config <workspace-root config>` as an implementation detail while CWD stays at the invocation directory, so "`--config` means CWD-relative" does not hold in practice - #24276 Impact should be small: bare names (`dist`, `*.min.js`) and `**/`-prefixed patterns are unaffected by the anchor. The updated `config_ignore_patterns/with_oxlintrc` snapshot shows the `--config` case.

…de the config directory (#24341) Follow up on #24339 - Added the same guard as Oxfmt - Since they are identical, I moved them into `oxc_config` so they can be shared

# Oxlint ### 🚀 Features - 0433a83 linter/eslint/no-inner-declarations: Add `namespaces` option (#24044) (Boshen) - 92f154a oxlint,oxfmt: Auto-discover `.mts` config files (#24357) (camc314) - 8c1d74b linter/import/no-duplicates: Add autofix logic (#24273) (Cole Ellison) ### 🐛 Bug Fixes - 0b086de linter/jest/prefer-lowercase-title: False positive when `lowercaseFirstCharacterOnly` is false (#24414) (Connor Shea) - 097cb95 linter: Allow `vite-plus/test` and `@effect as Vitest source (#24196) (Liang) - 8337835 linter: Error on `ignorePatterns` that cannot match files aoutside the config directory (#24341) (leaysgur) - 9ba30e5 linter/oxc/bad-replace-all-arg: Add note to enhance diagnostic (#24346) (camc314) - 2ce5a33 linter: Resolve `ignorePatterns` relative to the config dir (#24339) (leaysgur) - ab90eed linter/eslint/no-loop-func: Do not error on catch variables (#24316) (Chris Opperwall) - b67f0a6 linter/eslint/no-unused-vars: Count default parameter updates as usage (#24323) (camc314) - d193f8e linter: Detect Junie agent env vars (#24277) (Jeevan Mohan Pawar) - 2aecf60 linter/eslint/no-unreachable: Handle `break` in switch stmts correctly (#24260) (camc314) ### ⚡ Performance - 7f80cac linter/vue/prop-name-casing: Precompile `ignoreProps` regex pattern (#24413) (connorshea) - 6272051 linter/typescript/no-require-imports: Compile allow patterns once (#24417) (connorshea) - fb1edf1 linter: Compute comment fix span only for directive comments (#24419) (connorshea) - 33805b9 linter/jsdoc/require-param: Compile checkTypesPattern regex once (#24420) (connorshea) - 8de6fca linter/jest/valid-title: Compile disallowedWords regex once (#24412) (Connor Shea) - 4a0d8dc linter/eslint/no-underscore-dangle: Avoid String clone per identifier (#24371) (Ian Macalinao) - f3ab04c linter/typescript/consistent-type-imports: Remove redundant Vec per violation (#24370) (Ian Macalinao) - 4d2d78d linter/typescript/prefer-ts-expect-error: Avoid String clone per comment (#24369) (Ian Macalinao) # Oxfmt ### 🚀 Features - 3a7fe74 formatter_css: Update oxc-css-parser to 0.0.7 (#24434) (leaysgur) - 0173cd3 formatter_css: Format Less :extend and merge props (#24358) (leaysgur) - 92f154a oxlint,oxfmt: Auto-discover `.mts` config files (#24357) (camc314) - df250df formatter: Support `quoteProps` for TS enum and methods (#24309) (leaysgur) - a9a5cd6 formatter_core: Expose `SourceText::as_str()` (#24281) (leaysgur) ### 🐛 Bug Fixes - 162bddf formatter: Add required parens for conditional type in type parameter constraint (#24450) (leaysgur) - 2d22a91 formatter: Determine type cast target from span instead of lexical scan (#24447) (leaysgur) - 25306e9 formatter: Do not add extra parens with type cast comment (#24444) (leaysgur) - bd6edfe formatter: Break arrow signature that exactly fills the line when cond body may hug (#24440) (leaysgur) - a99ef41 formatter: Keep quotes on method signature named new (#24432) (leaysgur) - fcc28df formatter_css: Keep glued-braket-value tight (#24352) (leaysgur) - 8337835 linter: Error on `ignorePatterns` that cannot match files aoutside the config directory (#24341) (leaysgur) - b7c7e15 formatter: Add parens for import and private field in new callee chain (#24320) (leaysgur) - 0c8f6e4 formatter: Update detect_code_removal for #24309 (#24314) (leaysgur) - a85aad0 formatter: Fix member-chain and non-null parens (#24312) (leaysgur) - 1c29c73 formatter: Preserve `TSNonNullExpression` in chain expression (#24311) (leaysgur) - 8933c0e formatter: Keep comment inside of empty `switch` block (#24308) (leaysgur) - ec26af2 formatter: Preserve blank lines between JSX attrs (#24290) (leaysgur) - 70bd54d formatter: Keep arrow function body comment (#24287) (leaysgur) - 415fe1e oxfmt: Error on ignorePatterns that cannot match files outside the config directory (#24286) (leaysgur) - eeabc4a formatter_css: Bail on EOF-recovered parse errors (#24282) (leaysgur) - 42ec8de formatter: Keep comments inside surviving parens and suppressed statement terminators (#24253) (leaysgur) - 1343779 formatter: Keep comment inline for empty statements (#24249) (leaysgur) - b996579 formatter: Print ; before trailing comments part 2 (#24246) (leaysgur) - 4f86e8c formatter: Print `;` before trailing comments (#24244) (leaysgur) - 01252e4 formatter: Add or remove parens for `let` declaration (#24215) (leaysgur) ### ⚡ Performance - eeb1913 formatter_core: Avoid per-call `Vec` work-stack in soft-line removal (#23775) (Marius Schulz) - a2f255b formatter: Use `SmallVec` for `MemberChain` collections (#23776) (Marius Schulz) ### 📚 Documentation - b52d0f5 formatter: Add TODO comment about unsound code (#24372) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

leaysgur requested a review from camc314 as a code owner July 10, 2026 04:28

github-actions Bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Jul 10, 2026

leaysgur changed the title ~~fix(oxlint): resolve ignorePatterns relative to the config dir~~ fix(oxlint): resolve ignorePatterns relative to the config dir Jul 10, 2026

leaysgur force-pushed the 07-09-fix_oxlint_resolve_ignorepatterns_relative_to_the_config_dir branch 3 times, most recently from db6f15b to 9954da7 Compare July 10, 2026 05:07

leaysgur mentioned this pull request Jul 10, 2026

fix(linter): error on ignorePatterns that cannot match files aoutside the config directory #24341

Merged

leaysgur assigned camc314 Jul 10, 2026

camc314 approved these changes Jul 10, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2026

camc314 changed the title ~~fix(oxlint): resolve ignorePatterns relative to the config dir~~ fix(linter): resolve ignorePatterns relative to the config dir Jul 10, 2026

graphite-app Bot force-pushed the 07-09-fix_oxlint_resolve_ignorepatterns_relative_to_the_config_dir branch from 9954da7 to 2ce5a33 Compare July 10, 2026 08:40

graphite-app Bot merged commit 2ce5a33 into main Jul 10, 2026
29 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 10, 2026

graphite-app Bot deleted the 07-09-fix_oxlint_resolve_ignorepatterns_relative_to_the_config_dir branch July 10, 2026 08:45

oxc-guard Bot mentioned this pull request Jul 13, 2026

release(apps): oxlint v1.74.0 && oxfmt v0.59.0 #24454

Merged

antoinezanardi mentioned this pull request Jul 15, 2026

linter: ignorePatterns cannot match files outside config file's directory tree after PR #24339 fix #24545

Open

Andrew-Chen-Wang mentioned this pull request Jul 15, 2026

Migrate shadcn to base-nova, add SeoLink pattern, upgrade dependencies Andrew-Chen-Wang/nextjs-spa-split#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter): resolve `ignorePatterns` relative to the config dir#24339

fix(linter): resolve `ignorePatterns` relative to the config dir#24339
graphite-app[bot] merged 1 commit into
mainfrom
07-09-fix_oxlint_resolve_ignorepatterns_relative_to_the_config_dir

leaysgur commented Jul 10, 2026 •

edited

Loading

Uh oh!

leaysgur commented Jul 10, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

camc314 left a comment

Uh oh!

camc314 commented Jul 10, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

leaysgur commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Behavior change

Uh oh!

leaysgur commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Jul 10, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leaysgur commented Jul 10, 2026 •

edited

Loading

leaysgur commented Jul 10, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 10, 2026 •

edited

Loading

camc314 commented Jul 10, 2026 •

edited by graphite-app Bot

Loading