Skip to content

Remove references to cleanModules job - #1677

Merged
alexcjohnson merged 1 commit into
devfrom
remove-clean
Jun 29, 2021
Merged

Remove references to cleanModules job#1677
alexcjohnson merged 1 commit into
devfrom
remove-clean

Conversation

@HammadTheOne

Copy link
Copy Markdown
Contributor

This PR provides a minor fix to the dash-renderer build process by removing the job to clean node_modules following the bundle generation. As pointed out by @alexcjohnson , this job is unnecessary and causes the following error:

> rm -rf lib && babel src --extensions=".ts,.tsx,.js,.jsx" --out-dir lib --copy-files
sh: babel: command not found

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💃

@alexcjohnson
alexcjohnson merged commit e921450 into dev Jun 29, 2021
@alexcjohnson
alexcjohnson deleted the remove-clean branch June 29, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants