Skip to content

Remove references to cleanModules job #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcjohnson merged 1 commit into from
Jun 29, 2021
Merged

Remove references to cleanModules job #1677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions dash/development/build_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ def build(self, build=None):
self.npm()
self.bundles(build)
self.digest()
self.cleanModules()

@job("compute the hash digest for assets")
def digest(self):
Expand Down Expand Up @@ -156,12 +155,6 @@ def bundles(self, build=None):
) as fp:
fp.write(t.safe_substitute(versions))

@job("clean node_modules directory 🧹")
def cleanModules(self):
"""Job to clean node_modules directory from Dash package."""
os.chdir(self.main)
run_command_with_process("rm -rf node_modules")


class Renderer(BuildProcess):
def __init__(self):
Expand Down