Fix bump-hermes-version.js to write hermes-v prefixed tag to .hermesv1version (#57619)#57619
Closed
zeyap wants to merge 1 commit into
Closed
Fix bump-hermes-version.js to write hermes-v prefixed tag to .hermesv1version (#57619)#57619zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has imported this pull request. If you are a Meta employee, you can view this in D112846952. |
cortinico
approved these changes
Jul 20, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…1version (#57619) Summary: `scripts/hermes/bump-hermes-version.js` fetches the **bare** `hermes-compiler` npm version (e.g. `250829098.0.16`) and wrote it verbatim into `packages/react-native/sdks/.hermesv1version` via `setHermesTag`. But `.hermesv1version` is consumed by the Android Gradle build as a **git ref** to download the Hermes source: ``` https://github.com/facebook/hermes/tarball/<ref> (ReactAndroid/hermes-engine/build.gradle.kts) ``` Release tags on `facebook/hermes` are named `hermes-v<version>` (e.g. `hermes-v250829098.0.16`). The bare value `250829098.0.16` is not a valid ref → **HTTP 404**, which breaks the `build_fantom_runner` / `downloadHermes` build. ### Fix Normalize so `.hermesv1version` gets the `hermes-v`-prefixed **git tag**, while the `hermes-compiler` / prebuilt dependency versions (npm + Maven `HERMES_VERSION_NAME`) stay **bare**. Handles both bare and already-prefixed input. Test Plan: - `curl -sL -o /dev/null -w '%{http_code}' https://github.com/facebook/hermes/tarball/hermes-v250829098.0.16` → **200** (bare `250829098.0.16` → 404). - After running the bump: `.hermesv1version` = `hermes-v<version>`; `hermes-compiler` dep and `HERMES_VERSION_NAME` remain the bare version. Reviewed By: cortinico Differential Revision: D112846952 Pulled By: zeyap
meta-codesync
Bot
force-pushed
the
zeyap/fix-hermes-bump-tag-prefix
branch
from
July 20, 2026 18:12
e1b27f2 to
a0658ef
Compare
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112846952. |
…1version (#57619) Summary: ## Changelog: [Internal] - Fix bump-hermes-version.js to write hermes-v prefixed tag to .hermesv1version `scripts/hermes/bump-hermes-version.js` fetches the **bare** `hermes-compiler` npm version (e.g. `250829098.0.16`) and wrote it verbatim into `packages/react-native/sdks/.hermesv1version` via `setHermesTag`. But `.hermesv1version` is consumed by the Android Gradle build as a **git ref** to download the Hermes source: ``` https://github.com/facebook/hermes/tarball/<ref> (ReactAndroid/hermes-engine/build.gradle.kts) ``` Release tags on `facebook/hermes` are named `hermes-v<version>` (e.g. `hermes-v250829098.0.16`). The bare value `250829098.0.16` is not a valid ref → **HTTP 404**, which breaks the `build_fantom_runner` / `downloadHermes` build. ### Fix Normalize so `.hermesv1version` gets the `hermes-v`-prefixed **git tag**, while the `hermes-compiler` / prebuilt dependency versions (npm + Maven `HERMES_VERSION_NAME`) stay **bare**. Handles both bare and already-prefixed input. Test Plan: - `curl -sL -o /dev/null -w '%{http_code}' https://github.com/facebook/hermes/tarball/hermes-v250829098.0.16` → **200** (bare `250829098.0.16` → 404). - After running the bump: `.hermesv1version` = `hermes-v<version>`; `hermes-compiler` dep and `HERMES_VERSION_NAME` remain the bare version. Reviewed By: cortinico Differential Revision: D112846952 Pulled By: zeyap
meta-codesync
Bot
force-pushed
the
zeyap/fix-hermes-bump-tag-prefix
branch
from
July 20, 2026 18:13
a0658ef to
4f4fd54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - Fix bump-hermes-version.js to write hermes-v prefixed tag to .hermesv1version
scripts/hermes/bump-hermes-version.jsfetches the barehermes-compilernpm version (e.g.250829098.0.16) and wrote it verbatim intopackages/react-native/sdks/.hermesv1versionviasetHermesTag.But
.hermesv1versionis consumed by the Android Gradle build as a git ref to download the Hermes source:Release tags on
facebook/hermesare namedhermes-v<version>(e.g.hermes-v250829098.0.16). The bare value250829098.0.16is not a valid ref → HTTP 404, which breaks thebuild_fantom_runner/downloadHermesbuild.Fix
Normalize so
.hermesv1versiongets thehermes-v-prefixed git tag, while thehermes-compiler/ prebuilt dependency versions (npm + MavenHERMES_VERSION_NAME) stay bare. Handles both bare and already-prefixed input.Test Plan:
curl -sL -o /dev/null -w '%{http_code}' https://github.com/facebook/hermes/tarball/hermes-v250829098.0.16→ 200 (bare250829098.0.16→ 404)..hermesv1version=hermes-v<version>;hermes-compilerdep andHERMES_VERSION_NAMEremain the bare version.Reviewed By: cortinico
Differential Revision: D112846952
Pulled By: zeyap