[LOCAL] Set .hermesv1version to hermes-v250829098.0.16#57620
Merged
Conversation
Summary: The Android Gradle build downloads the Hermes source from https://github.com/facebook/hermes/tarball/<ref>, where <ref> is the contents of sdks/.hermesv1version. Release tags on facebook/hermes are named hermes-v<version>, so the bare value 250829098.0.16 404s and breaks the build_fantom_runner / downloadHermes build. Pin to the hermes-v prefixed tag. Test Plan: curl -sL -o /dev/null -w '%{http_code}' \ https://github.com/facebook/hermes/tarball/hermes-v250829098.0.16 => 200
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Android Gradle build downloads the Hermes source from
https://github.com/facebook/hermes/tarball/<ref>(ReactAndroid/hermes-engine/build.gradle.kts), where<ref>is the contents ofpackages/react-native/sdks/.hermesv1version.Release tags on
facebook/hermesare namedhermes-v<version>(e.g.hermes-v250829098.0.16), so the bare value250829098.0.16is not a valid ref → HTTP 404, breaking thebuild_fantom_runner/downloadHermesbuild.This pins
.hermesv1versionto thehermes-v-prefixed git tag.Test Plan
(bare
250829098.0.16→ 404)