Skip to content

Flush created animated nodes before handling events (#57656)#57656

Open
sbuggay wants to merge 1 commit into
react:mainfrom
sbuggay:export-D111257551
Open

Flush created animated nodes before handling events (#57656)#57656
sbuggay wants to merge 1 commit into
react:mainfrom
sbuggay:export-D111257551

Conversation

@sbuggay

@sbuggay sbuggay commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary:

Changelog: [Internal]

View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.

There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.

Differential Revision: D111257551

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown

@sbuggay has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111257551.

sbuggay added a commit to sbuggay/react-native that referenced this pull request Jul 23, 2026
Summary:
Pull Request resolved: react#57656

Changelog: [Internal]

View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.

There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.

Differential Revision: D111257551
@meta-codesync meta-codesync Bot changed the title Flush created animated nodes before handling events Flush created animated nodes before handling events (#57656) Jul 23, 2026
@sbuggay
sbuggay force-pushed the export-D111257551 branch from 62fde23 to 1fda133 Compare July 23, 2026 20:12
sbuggay added a commit to sbuggay/react-native that referenced this pull request Jul 23, 2026
Summary:

Changelog: [Internal]

View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.


There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.

Differential Revision: D111257551
@sbuggay
sbuggay force-pushed the export-D111257551 branch from 1fda133 to c387418 Compare July 23, 2026 21:55
sbuggay added a commit to sbuggay/react-native that referenced this pull request Jul 23, 2026
Summary:

Changelog: [Internal]

View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.


There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.

Differential Revision: D111257551
@sbuggay
sbuggay force-pushed the export-D111257551 branch from c387418 to 76d619c Compare July 23, 2026 22:06
Summary:

Changelog: [Internal]

View event handlers can run synchronously before NativeAnimated nodes created on the async path have been flushed into the active graph. Flush pending async-created nodes on the render thread before evaluating a view event, so focus-driven animations can resolve their value nodes on the first native focus event instead of needing another runloop/event.


There was a very frequent problem in airwave-tvos where a view would not receive it's NVE focus event on the commit it was created, this solves that problem without having to naively re-emit the focus event.

Differential Revision: D111257551
@sbuggay
sbuggay force-pushed the export-D111257551 branch from 76d619c to 5ebe9ae Compare July 24, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant