Skip to content

Flush created animated nodes before handling events (#57656) #57656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbuggay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Flush created animated nodes before handling events (#57656) #57656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,15 +208,15 @@ class NativeAnimatedNodesManager : public std::enable_shared_from_this<NativeAni

bool isOnRenderThread() const noexcept;

void flushAnimatedNodesCreatedAsync() noexcept;

void resolvePlatformColor(SurfaceId surfaceId, const RawValue &value, SharedColor &result) const;

private:
void stopRenderCallbackIfNeeded(bool isAsync) noexcept;

bool onAnimationFrame(double timestamp);

void flushAnimatedNodesCreatedAsync() noexcept;

bool isAnimationUpdateNeeded() const noexcept;

void stopAnimationsForNode(Tag nodeTag);
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3523,6 +3523,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3407,6 +3407,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3520,6 +3520,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5756,6 +5756,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5668,6 +5668,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5753,6 +5753,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,6 +2365,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2289,6 +2289,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
1 change: 1 addition & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,6 +2362,7 @@ class facebook::react::NativeAnimatedNodesManager : public std::enable_shared_fr
public void dropAnimatedNode(facebook::react::Tag tag) noexcept;
public void extractAnimatedNodeOffsetOp(facebook::react::Tag tag);
public void flattenAnimatedNodeOffset(facebook::react::Tag tag);
public void flushAnimatedNodesCreatedAsync() noexcept;
public void insertMutations(std::unordered_map<facebook::react::Tag, std::pair<facebook::react::ShadowNodeFamily::Weak, folly::dynamic>>& updates, facebook::react::AnimationMutations& mutations, facebook::react::AnimatedPropsBuilder& propsBuilder, bool hasLayoutUpdates = false);
public void onManagedPropsRemoved(facebook::react::Tag tag) noexcept;
public void onRender();
Expand Down
Loading