[TRI-1366] fix: JobRun needs an internal boolean column, to reflect the value in Job

[ericallam]

We use internal jobs for things like webhook registration, and those jobs have internal = true set in the database. We also need to add an internal column to JobRun that is set to true when the job it's associated with is internal = true. This is just denormalization, so when we do usage queries (in the new usage page) we can easily eliminate internal runs from the usage. The migration for this should upgrade existing runs to the correct internal value.

_TRI-1366

[0x0elliot]

interesting. so literally, just add in "internal" with the default value as "true" in the postgres ts migrations?

still slightly confused about what to do. doesn't seem as simple as what i thought it was.

[0x0elliot]

probably not this since it's already here 🤔

[karti16]

@0x0elliot the 'JobRun' table internal column should have value based on 'Job' table internal column. While creating new jobrun value can be set. But I can't come up how to set values for the existing jobrun rows in the table.

[karti16]

probably not this since it's already here 🤔

To be added in JobRun table

[0x0elliot]

oh that makes sense. are you handling this then :)?

probably not this since it's already here 🤔

To be added in JobRun table

[karti16]

oh that makes sense. are you handling this then :)?

probably not this since it's already here 🤔

To be added in JobRun table

I may need some help. I didn't start working on this. If you can figure out. That's okay too.

[0x0elliot]

i might be able to solve this quick. i haven't slept today however, so no promises :P

i hope that's okay? @karti16

[0x0elliot]

#561

will do the testing in a bit. please wait for my thumbs up before merge :3

[karti16]

@0x0elliot working as expected ?