Skip to content

feat: add internal flag to job-run table#563

Merged
ericallam merged 3 commits into
triggerdotdev:mainfrom
hmacr:issue-557-add-job-run-internal
Oct 6, 2023
Merged

feat: add internal flag to job-run table#563
ericallam merged 3 commits into
triggerdotdev:mainfrom
hmacr:issue-557-add-job-run-internal

Conversation

@hmacr

@hmacr hmacr commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Closes #557

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Verified the migration is applied and the column is added to JobRun table.
  • Verified the new job runs are using the internal flag from Job table (I did this by manually updating the internal flag for one of the jobs).

Changelog

  • Add new column internal in JobRun table (defaults to false)
  • Set JobRun internal flag based on the job's definition in the createRun API.

💯

@changeset-bot

changeset-bot Bot commented Oct 5, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e1ffecd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam

Copy link
Copy Markdown
Member

@hmacr Actually I think you should move that backfill SQL query into the packages/database/prisma/migrations/20231005064823_add_job_run_internal/migration.sql migration file in this PR, and go ahead and close #564

@hmacr

hmacr commented Oct 6, 2023

Copy link
Copy Markdown
Contributor Author

@ericallam I've moved the query as suggested.

@ericallam
ericallam merged commit 1c524c5 into triggerdotdev:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1366] fix: JobRun needs an internal boolean column, to reflect the value in Job

2 participants