perf(codecs): reduce allocations in OTLP metric conversion#25928
Open
bruceg wants to merge 2 commits into
Open
perf(codecs): reduce allocations in OTLP metric conversion#25928bruceg wants to merge 2 commits into
bruceg wants to merge 2 commits into
Conversation
Pass metric data by ownership through the OTLP metric encode and decode paths to avoid redundant allocations: - metric_event_to_export_request and split_metric_tags now consume the owned Metric/MetricTags, moving tag keys/values, metric name, buckets, and quantiles instead of cloning them (added MetricTags::into_iter_sets). - build_metric_tags takes its attributes by value and moves keys/values. - ResourceMetrics::into_event_iter (decode path) moves the metric name and drops the redundant per-metric resource/scope pre-clones.
petere-datadog
approved these changes
Jul 22, 2026
Comment on lines
+459
to
+464
| if key.starts_with(RESOURCE_PREFIX) { | ||
| key.drain(..RESOURCE_PREFIX.len()); | ||
| push_key_value(&mut resource_attributes, key, value); | ||
| } else if key.starts_with(SCOPE_PREFIX) { | ||
| key.drain(..SCOPE_PREFIX.len()); | ||
| push_key_value(&mut scope_attributes, key, value); |
Member
There was a problem hiding this comment.
strip_prefix reads a little better here. Are you able to benchmark if the &str conversion makes any difference here?
Member
Author
There was a problem hiding this comment.
It appears to cause a repeatable ~4% regression with strip_prefix over this drain setup. Ideally we could use String::replace_first or String::remove_matches but those are still unstable and don't return if they made any changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass metric data by ownership through the OTLP metric encode paths to avoid redundant allocations:
Note that I did not include a changelog as the feature itself was noted in the changelogs and is not yet present in a release.
Vector configuration
N/A used #25923 to validate
How did you test this PR?
Running
cargo bench --package codecs --features opentelemetry otlp/encodebefore and after the change shows an improvement in throughput of 10-52% depending on the metric data. Handling of labels/tags showed the largest improvements.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.