terminal: Enable copy and paste in edit menu - #58111
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
dinocosta
added
the
area:integrations/terminal
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Resolves zed-industries#57999 This diff fixes the macOS Edit menu showing Copy and Paste as disabled when a terminal is focused. Terminal shortcuts already worked because keybindings dispatch `terminal::Copy` and `terminal::Paste`, but the app menu validates `editor::Copy` and `editor::Paste`, which the terminal view did not expose. With this change, the terminal view handles the editor Copy and Paste actions by delegating to the existing terminal copy and paste paths. This keeps keyboard behavior unchanged while allowing menu validation and menu dispatch to work correctly for focused terminals. Release Notes: - Fixed `Copy` and `Paste` being disabled in the macOS `Edit` menu when a terminal is focused. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Resolves zed-industries#57999 This diff fixes the macOS Edit menu showing Copy and Paste as disabled when a terminal is focused. Terminal shortcuts already worked because keybindings dispatch `terminal::Copy` and `terminal::Paste`, but the app menu validates `editor::Copy` and `editor::Paste`, which the terminal view did not expose. With this change, the terminal view handles the editor Copy and Paste actions by delegating to the existing terminal copy and paste paths. This keeps keyboard behavior unchanged while allowing menu validation and menu dispatch to work correctly for focused terminals. Release Notes: - Fixed `Copy` and `Paste` being disabled in the macOS `Edit` menu when a terminal is focused. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57999
This diff fixes the macOS Edit menu showing Copy and Paste as disabled when a terminal is focused. Terminal shortcuts already worked because keybindings dispatch
terminal::Copyandterminal::Paste, but the app menu validateseditor::Copyandeditor::Paste, which the terminal view did not expose.With this change, the terminal view handles the editor Copy and Paste actions by delegating to the existing terminal copy and paste paths. This keeps keyboard behavior unchanged while allowing menu validation and menu dispatch to work correctly for focused terminals.
Release Notes:
CopyandPastebeing disabled in the macOSEditmenu when a terminal is focused.