fix/linked images clickable - #59518
Closed
WaryaWayne wants to merge 4 commits into
Closed
Conversation
Make images inside markdown links clickable
Make images nested inside markdown links behave like normal markdown links by adding pointer/click handling to the rendered image wrapper. Linked images now use the markdown URL click handler when present, fall back to opening the URL directly, respect prevent_mouse_interaction, and capture right-clicked links for context menus. Verification: - cargo test -p markdown: 95 passed - Built after fixing earlier compile errors from non-existent methods - Manually verified markdown preview badge/image links open and right-click shows Copy Link
markdown: Make linked images clickable
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: BDM Headquarters.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Componenttrait (component_preview: Clean upComponenttrait #57731)headerandmouseout ofelement.rs(editor: Extractheaderandmouseout ofelement.rs#57472)convert_caseto v0.11.0 (Bumpconvert_caseto v0.11.0 #58000)create_highlight_endpoints(Improve performance ofcreate_highlight_endpoints#58119)flex_grow()andflex_shrink()with custom factors (gpui: Allow chainingflex_grow()andflex_shrink()with custom factors #58142)conda activate basefor nameless toolchains (python: Stop falling back toconda activate basefor nameless toolchains #56785)devEnginespackage manager for package scripts (languages: RespectdevEnginespackage manager for package scripts #58113)DisplayMap::highlight_textnot always sorting its ranges (editor: FixDisplayMap::highlight_textnot always sorting its ranges #58260)git_graphintogit_ui(git_ui: Movegit_graphintogit_ui#57503)github_user_idandgithub_logincolumns in tests (collab: Only accessgithub_user_idandgithub_logincolumns in tests #58457)ca0fd8d(extension_ci: Bump extension CLI version toca0fd8d#58476)csharp-lsby default (Disablecsharp-lsby default #58507)github_user_idandgithub_login(collab: Remove writes togithub_user_idandgithub_login#58474)fishmodelines as Shell Script (grammars: Stop treatingfishmodelines as Shell Script #58550)envrcto Shell Scriptpath_suffixes(Addenvrcto Shell Scriptpath_suffixes#58573)/create-skill(agent_skills: Instruct agent not to include unrelated instructions in/create-skill#58599)Sidebar::update_entries(sidebar: DebounceSidebar::update_entries#57803)9ee3c50(extension_ci: Bump extension CLI version to9ee3c50#58785)SHORT_SHA_LENGTHfor all shortened commit SHAs (UseSHORT_SHA_LENGTHfor all shortened commit SHAs #58741)cli.exedirectly (Fix SSH askpass on Windows by invokingcli.exedirectly #52491)TestScheduler::spawn_dedicatedleaking due to cycle (FixTestScheduler::spawn_dedicatedleaking due to cycle #58802)Add to .git/info/excludeoption to context menus (git_ui: AddAdd to .git/info/excludeoption to context menus #57044)zed://links clickable in terminal (Makezed://links clickable in terminal #58910)/compact(agent: Hide token usage after running/compact#58937)BufferDiffto allow multiple diffs to share the same base text buffer (RefactorBufferDiffto allow multiple diffs to share the same base text buffer #58266)auto_update_extensionssetting (Documentauto_update_extensionssetting #58954)didChangeWatchedFileshandler performance (ImprovedidChangeWatchedFileshandler performance #59078)alphamethod toRgba(gpui: Addalphamethod toRgba#52125)BufferSnapshotinrange_to_buffer_ranges(multi_buffer: Don't eagerly cloneBufferSnapshotinrange_to_buffer_ranges#59190)git stash liston every file save (git: Do not rungit stash liston every file save #59042)RebuildDevExtensionaction (extensions_ui: AddRebuildDevExtensionaction #55173)mermantag SHA (Updatemermantag SHA #59360)async-process(Remove gpui's dependency onasync-process#59358).gitdirectory being removed from watcher when excluded viafile_scan_exclusions(git: Fix.gitdirectory being removed from watcher when excluded viafile_scan_exclusions#57895)paint_search_highlights(markdown: Optimizepaint_search_highlights#59473)alacritty_terminalrepo SHA (Bumpalacritty_terminalrepo SHA #59445)