Fix all internal JSDoc comments#14
Closed
jakebailey wants to merge 1 commit into
Closed
Conversation
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 16:52
7bb2d56 to
efaf2d7
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 16:52
739e71d to
a31b0ef
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 20:27
efaf2d7 to
9d46c28
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 20:27
a31b0ef to
223a3f5
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:02
9d46c28 to
2e6b763
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:02
223a3f5 to
9b79d42
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:47
2e6b763 to
0c5afda
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:47
9b79d42 to
72d390c
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:58
0c5afda to
bb1c98d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:58
72d390c to
ff637c0
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 23:22
bb1c98d to
b75e466
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 23:22
ff637c0 to
40f3f72
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 14, 2022 17:26
b75e466 to
980ee49
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 14, 2022 17:26
40f3f72 to
d4005a7
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 04:35
980ee49 to
ee7ee41
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:35
d4005a7 to
c80e914
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 04:37
ee7ee41 to
8debd97
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:37
c80e914 to
1764185
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 05:43
8debd97 to
d7091d6
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 05:43
1764185 to
ebf0539
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 19, 2022 20:11
d7091d6 to
7d9b69a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:11
ebf0539 to
22a440a
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 19, 2022 20:37
7d9b69a to
df9f2b8
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:38
22a440a to
e744bbc
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 20, 2022 05:06
df9f2b8 to
d6035b0
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:06
e744bbc to
0d8842b
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 20, 2022 05:10
d6035b0 to
94dedfd
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:10
0d8842b to
99362b4
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 28, 2022 00:44
3fc9a56 to
d833e19
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 00:44
e900d70 to
8756a16
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 28, 2022 05:03
d833e19 to
5db64db
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 05:04
8756a16 to
7d2ba94
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 28, 2022 07:45
5db64db to
14b661f
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 07:45
7d2ba94 to
521087f
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 28, 2022 19:39
14b661f to
b88e02d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 19:39
521087f to
3b3a4fb
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 28, 2022 22:03
b88e02d to
bdc78f6
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 22:03
3b3a4fb to
473bb4d
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 3, 2022 21:40
bdc78f6 to
e800ad6
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 3, 2022 21:40
473bb4d to
e59a783
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 3, 2022 23:33
e800ad6 to
62f8659
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 3, 2022 23:33
e59a783 to
34301ab
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 17:58
62f8659 to
6c64a76
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 17:58
34301ab to
c36c875
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 19:05
6c64a76 to
f76ac09
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 19:05
c36c875 to
5fd5dca
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 19:52
f76ac09 to
a4470da
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 19:52
5fd5dca to
56e74d3
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 21:01
a4470da to
8bdc7e3
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 21:01
56e74d3 to
f604298
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 22:18
8bdc7e3 to
f41114e
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 22:18
f604298 to
517eee8
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 22:48
f41114e to
70ccef6
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 22:48
517eee8 to
f54e048
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 4, 2022 23:13
70ccef6 to
9c31e73
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 23:13
f54e048 to
c58c1e4
Compare
If these are regular comments, then they won't appear in our d.ts files. But, now we are relying on an external d.ts bundler to produce our final merged, so they need to be present in the "input" d.ts files, meaning they have to be JSDoc comments. These comments only work today because all of our builds load their TS files from scratch, so they see the actual source files and their non-JSDoc comments. The comments also need to be attached to a declaration, not floating, otherwise they won't be used by api-extractor, so move them if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If these are regular comments, then they won't appear in our d.ts files.
But, now we are relying on an external d.ts bundler to produce our final
merged, so they need to be present in the "input" d.ts files, meaning
they have to be JSDoc comments.
These comments only work today because all of our builds load their TS
files from scratch, so they see the actual source files and their
non-JSDoc comments.
The comments also need to be attached to a declaration, not floating,
otherwise they won't be used by api-extractor, so move them if needed.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: