Skip to content

Directly import namespaces for improved esbuild output#31

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-28from
transform-stack-commit-29
Closed

Directly import namespaces for improved esbuild output#31
jakebailey wants to merge 1 commit into
transform-stack-commit-28from
transform-stack-commit-29

Conversation

@jakebailey

@jakebailey jakebailey commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

I should report this upstream, if I can manage to minimize this.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output (this PR)
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 586a05e to 5b31ac2 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 6f93bd7 to 638ebf8 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 5b31ac2 to 7a5cd70 Compare October 4, 2022 18:00
@jakebailey jakebailey changed the title Add ts to globalThis for convenience during debugging Undo changes needed to load codebase into ts-morph Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 638ebf8 to ddc6627 Compare October 4, 2022 18:00
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 7a5cd70 to d38dfd9 Compare October 4, 2022 19:07
@jakebailey jakebailey changed the title Undo changes needed to load codebase into ts-morph Restore self-compilation using built compiler in CI tests Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from ddc6627 to 29fa121 Compare October 4, 2022 19:07
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from d38dfd9 to 9ca6bf1 Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 29fa121 to df3357f Compare October 4, 2022 19:54
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch 4 times, most recently from f10b875 to d3deabd Compare October 9, 2022 00:42
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Use jsonc-parser instead of LKG compiler in build Oct 9, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from df3357f to 68929dd Compare October 9, 2022 00:42
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from d3deabd to f0607de Compare October 10, 2022 17:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 68929dd to 5d22fdb Compare October 10, 2022 17:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from f0607de to e4bcd8e Compare October 10, 2022 21:05
@jakebailey jakebailey changed the title Use jsonc-parser instead of LKG compiler in build Temporarily disable template literals Oct 10, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch 2 times, most recently from a520d61 to 5844106 Compare October 10, 2022 22:55
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 2925d14 to 792c2cb Compare October 10, 2022 23:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 5844106 to 2977b78 Compare October 10, 2022 23:14
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 792c2cb to 7006861 Compare October 10, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 2977b78 to a10c176 Compare October 10, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 7006861 to 6778006 Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from a10c176 to 6b92337 Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 6778006 to b4f2f48 Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 6b92337 to b0404d2 Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 0b26bce to fc794a7 Compare October 20, 2022 00:50
@jakebailey jakebailey changed the title Use jsonc-parser instead of LKG compiler in build Change build system to hereby Oct 20, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from f973c4b to e944144 Compare October 20, 2022 00:50
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from fc794a7 to 6c48107 Compare October 20, 2022 01:25
@jakebailey jakebailey changed the title Change build system to hereby Switch to faster XML parsing library for localize Oct 20, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from e944144 to e064258 Compare October 20, 2022 01:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 6c48107 to 8d562f1 Compare October 20, 2022 20:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from e064258 to e8d1e40 Compare October 20, 2022 20:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 8d562f1 to a3cb14a Compare October 20, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from e8d1e40 to 3cd03b4 Compare October 20, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from a3cb14a to 7c0bdab Compare October 21, 2022 23:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 3cd03b4 to 30d33b4 Compare October 21, 2022 23:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 7c0bdab to b99521a Compare October 22, 2022 16:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 30d33b4 to bd9148a Compare October 22, 2022 16:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from b99521a to c526320 Compare October 23, 2022 00:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from bd9148a to aeb3907 Compare October 23, 2022 00:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from c526320 to da3baf3 Compare October 24, 2022 04:38
@jakebailey jakebailey changed the title Switch to faster XML parsing library for localize Remove mkdirp Oct 24, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from aeb3907 to 943a958 Compare October 24, 2022 04:38
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from da3baf3 to f5f40bf Compare October 24, 2022 18:10
@jakebailey jakebailey changed the title Remove mkdirp Export ts namespace from tsserver for hacky-post patching Oct 24, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 943a958 to 8ae43ee Compare October 24, 2022 18:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from f5f40bf to 4a0a771 Compare October 24, 2022 20:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 8ae43ee to e349e38 Compare October 24, 2022 20:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 4a0a771 to 0708798 Compare October 24, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from e349e38 to 6a282bf Compare October 24, 2022 23:15
@jakebailey jakebailey changed the title Export ts namespace from tsserver for hacky-post patching Directly import namespaces for improved esbuild output Oct 24, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-28 branch from 0708798 to 35d4b72 Compare October 25, 2022 02:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-29 branch from 6a282bf to 3d30fcf Compare October 25, 2022 02:24
@jakebailey
Directly import namespaces for improved esbuild output
fa143d7 
I should report this upstream, if I can manage to minimize this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey