Skip to content

Add gitlens settings suggestion#8

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-7from
transform-stack-commit-8
Closed

Add gitlens settings suggestion#8
jakebailey wants to merge 1 commit into
transform-stack-commit-7from
transform-stack-commit-8

Conversation

@jakebailey

@jakebailey jakebailey commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

While GitHub automatically uses this file if present, GitLens in VS Code
does not. Add the right option to our example settings.json for those
who use the extension.

Unfortunately, you can't leave this enabled if you want to look at the
repo without the file; git blame just crashes when the file isn't
present. I'm not sure that there's a workaround for that.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion (this PR)
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 4bc100d to 2784548 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [7/8] Remove a bunch of namespace uses [8/8] Remove a bunch of namespace uses May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 1fe1940 to 2c43171 Compare May 27, 2022 04:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 2784548 to 1590a5c Compare May 27, 2022 04:23
@jakebailey jakebailey changed the title [8/8] Remove a bunch of namespace uses Remove a bunch of namespace uses May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 2c43171 to a94650d Compare May 27, 2022 04:23
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 1590a5c to 9ca16e2 Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from a94650d to c210b6a Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 9ca16e2 to 9a4d35c Compare May 27, 2022 18:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from c210b6a to fd22919 Compare May 27, 2022 18:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 9a4d35c to 171fb6e Compare May 27, 2022 18:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from fd22919 to 5a0276a Compare May 27, 2022 18:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 171fb6e to 8fad258 Compare May 27, 2022 18:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 5a0276a to 367479c Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 8fad258 to 3bced09 Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 367479c to 4831c6e Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 3bced09 to ef8b3dc Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 4831c6e to 42a5ee7 Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from ef8b3dc to ff4135c Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 42a5ee7 to 8b2dc85 Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from ff4135c to dbb5960 Compare May 27, 2022 22:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 8b2dc85 to 926060a Compare May 27, 2022 22:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from dbb5960 to 021768d Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 926060a to 3b6e30f Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 021768d to 4ccc889 Compare May 27, 2022 23:57
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 3b6e30f to 73f8cc9 Compare May 27, 2022 23:57
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 4ccc889 to 4167e86 Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 73f8cc9 to 0192dc8 Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 4167e86 to a0680c6 Compare May 28, 2022 01:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 0192dc8 to 63c269b Compare May 28, 2022 01:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 068a8f4 to b65a495 Compare July 26, 2022 23:06
@jakebailey jakebailey changed the title Add TODOs in Gulpfile Convert require calls to imports Jul 26, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from adcd7f5 to 6b054e4 Compare July 26, 2022 23:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from b65a495 to 021a96c Compare August 24, 2022 23:46
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 6b054e4 to 2df2f69 Compare August 24, 2022 23:46
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 021a96c to 478393c Compare August 25, 2022 19:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 2df2f69 to 7f6377b Compare August 25, 2022 19:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 478393c to fdafae4 Compare August 25, 2022 22:55
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 7f6377b to 3b3f987 Compare August 25, 2022 22:55
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from fdafae4 to 1b942c0 Compare August 26, 2022 20:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 3b3f987 to a8a6494 Compare August 26, 2022 20:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 1b942c0 to 66dc3bf Compare August 29, 2022 23:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from a8a6494 to a83784a Compare August 29, 2022 23:17
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 66dc3bf to e66aec7 Compare August 31, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from a83784a to 3773c3d Compare August 31, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from e66aec7 to fe481f9 Compare September 3, 2022 04:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 3773c3d to d5c7b08 Compare September 3, 2022 04:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from fe481f9 to 3af748e Compare September 3, 2022 04:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from d5c7b08 to 02d83cd Compare September 3, 2022 04:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 3af748e to 93b6edb Compare September 7, 2022 22:31
@jakebailey jakebailey changed the title Convert require calls to imports Make current state lint-clean Sep 7, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 02d83cd to 7519997 Compare September 7, 2022 22:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 93b6edb to 2f0b32f Compare September 13, 2022 16:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 7519997 to 2e49d60 Compare September 13, 2022 16:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 2f0b32f to 3c877c9 Compare September 13, 2022 20:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 2e49d60 to 0ada369 Compare September 13, 2022 20:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 3c877c9 to 0d36ff3 Compare September 13, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-8 branch from 0ada369 to da8cc97 Compare September 13, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-7 branch from 0d36ff3 to 1b283a0 Compare September 13, 2022 21:47
@jakebailey
Add gitlens settings suggestion
aeff496 
While GitHub automatically uses this file if present, GitLens in VS Code
does not. Add the right option to our example settings.json for those
who use the extension.

Unfortunately, you can't leave this enabled if you want to look at the
repo _without_ the file; git blame just crashes when the file isn't
present. I'm not sure that there's a workaround for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey