Skip to content

Generated module conversion step - unindent#3

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-2from
transform-stack-commit-3
Closed

Generated module conversion step - unindent#3
jakebailey wants to merge 1 commit into
transform-stack-commit-2from
transform-stack-commit-3

Conversation

@jakebailey

@jakebailey jakebailey commented May 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

This step makes further commits look clearer by unindenting all of the top level namespaces preemptively.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent (this PR)
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from e13cf71 to ebf5725 Compare May 14, 2022 22:18
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 1e12bf2 to f846641 Compare May 14, 2022 22:18
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from ebf5725 to a4af808 Compare May 14, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from f846641 to ac0cefd Compare May 14, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from a4af808 to 4cd003d Compare May 14, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from ac0cefd to bbaf149 Compare May 14, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 4cd003d to 1e02836 Compare May 14, 2022 22:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from bbaf149 to c5e0dc1 Compare May 14, 2022 22:22
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 1e02836 to 8f83dbb Compare May 14, 2022 22:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from c5e0dc1 to 1ad68ac Compare May 14, 2022 22:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 8f83dbb to a0d1d6b Compare May 14, 2022 22:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 1ad68ac to ef15a20 Compare May 14, 2022 22:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from a0d1d6b to 461a72f Compare May 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from ef15a20 to 60dae0f Compare May 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 461a72f to 29d02b1 Compare May 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 60dae0f to 1d0ae84 Compare May 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 29d02b1 to bb65665 Compare May 15, 2022 02:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 1d0ae84 to 9f480b6 Compare May 15, 2022 02:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from bb65665 to 98c1e64 Compare May 15, 2022 02:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 9f480b6 to bf0ee60 Compare May 15, 2022 02:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 98c1e64 to a70d5bd Compare May 15, 2022 02:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from bf0ee60 to de9dede Compare May 15, 2022 02:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from a70d5bd to e864b41 Compare May 15, 2022 02:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from de9dede to aa41b1f Compare May 15, 2022 02:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from e864b41 to 6f4e7a6 Compare May 15, 2022 03:04
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from aa41b1f to 4a471fd Compare May 15, 2022 03:04
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 6f4e7a6 to d197ea1 Compare May 17, 2022 00:43
@jakebailey jakebailey changed the title UNINDENT CONVERSION STEP - stripNamespaces May 17, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 4a471fd to 9683b0a Compare May 17, 2022 00:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from d197ea1 to 35432e3 Compare May 17, 2022 01:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch 2 times, most recently from 72e33b9 to 31d12ad Compare May 25, 2022 02:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch 2 times, most recently from b97a980 to b99119d Compare May 25, 2022 21:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 31d12ad to c4ee091 Compare May 25, 2022 21:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from b99119d to 383d1ca Compare May 25, 2022 21:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from c4ee091 to d8e7812 Compare May 25, 2022 21:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 383d1ca to 46e99c5 Compare May 25, 2022 21:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from d8e7812 to 0eb75ad Compare May 25, 2022 21:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 46e99c5 to be409c6 Compare May 25, 2022 21:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 0eb75ad to a92d585 Compare May 25, 2022 21:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from be409c6 to 6488b95 Compare May 25, 2022 21:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a92d585 to 20a1274 Compare May 25, 2022 21:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 6488b95 to 816e5b8 Compare May 26, 2022 03:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 20a1274 to bc5f2cf Compare May 26, 2022 03:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 816e5b8 to 43942d8 Compare May 26, 2022 21:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from bc5f2cf to 340cb2c Compare May 26, 2022 21:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 43942d8 to 003f75a Compare May 27, 2022 04:15
@jakebailey jakebailey changed the title CONVERSION STEP - explicitify [2/8] CONVERSION STEP - explicitify May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 340cb2c to a765a69 Compare May 27, 2022 04:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 003f75a to 3c6810b Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [2/8] CONVERSION STEP - explicitify [3/8] CONVERSION STEP - explicitify May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a765a69 to 68c89d8 Compare May 27, 2022 04:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 3c6810b to c105061 Compare May 27, 2022 04:22
@jakebailey jakebailey changed the title [3/8] CONVERSION STEP - explicitify CONVERSION STEP - explicitify May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 68c89d8 to b140a83 Compare May 27, 2022 04:23
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from c105061 to 0bf4701 Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from b140a83 to 9d2b41f Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-2 branch from 0bf4701 to 2962fc5 Compare May 27, 2022 18:24
@jakebailey
Generated module conversion step - unindent
f533e5f 
This step makes further commits look clearer by unindenting all of the top level namespaces preemptively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey