Skip to content

Generated module conversion step - explicitify#4

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-3from
transform-stack-commit-4
Closed

Generated module conversion step - explicitify#4
jakebailey wants to merge 1 commit into
transform-stack-commit-3from
transform-stack-commit-4

Conversation

@jakebailey

@jakebailey jakebailey commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

This step makes all implicit namespace accesses explicit, e.g. "Node" turns into "ts.Node".

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify (this PR)
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from c518af7 to 420bf65 Compare May 18, 2022 00:01
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 91e8c22 to 8885adb Compare May 18, 2022 00:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 420bf65 to 3648c44 Compare May 18, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 8885adb to 0e1d400 Compare May 18, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 3648c44 to a830489 Compare May 19, 2022 01:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 0e1d400 to d0b989b Compare May 19, 2022 01:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a830489 to 72e33b9 Compare May 25, 2022 01:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from d0b989b to 1ab00db Compare May 25, 2022 01:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 72e33b9 to 31d12ad Compare May 25, 2022 02:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 1ab00db to 6a10437 Compare May 25, 2022 02:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 31d12ad to c4ee091 Compare May 25, 2022 21:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 6a10437 to 65d3c7d Compare May 25, 2022 21:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from c4ee091 to d8e7812 Compare May 25, 2022 21:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 65d3c7d to 998d77a Compare May 25, 2022 21:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from d8e7812 to 0eb75ad Compare May 25, 2022 21:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 998d77a to c9d5bf0 Compare May 25, 2022 21:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 0eb75ad to a92d585 Compare May 25, 2022 21:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from c9d5bf0 to 13ef966 Compare May 25, 2022 21:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a92d585 to 20a1274 Compare May 25, 2022 21:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 13ef966 to aed7990 Compare May 25, 2022 21:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 20a1274 to bc5f2cf Compare May 26, 2022 03:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from aed7990 to 1a405d2 Compare May 26, 2022 03:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from bc5f2cf to 340cb2c Compare May 26, 2022 21:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 1a405d2 to f154eb7 Compare May 26, 2022 21:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 340cb2c to a765a69 Compare May 27, 2022 04:15
@jakebailey jakebailey changed the title CONVERSION STEP - stripNamespaces [3/8] CONVERSION STEP - stripNamespaces May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from f154eb7 to 6cf63ac Compare May 27, 2022 04:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a765a69 to 68c89d8 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [3/8] CONVERSION STEP - stripNamespaces [4/8] CONVERSION STEP - stripNamespaces May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 6cf63ac to 89d1af6 Compare May 27, 2022 04:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 46fd330 to 96b24d5 Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 1f536d2 to ddaf82f Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 96b24d5 to a5d3e34 Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from ddaf82f to 0705e51 Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from a5d3e34 to 50ef8b9 Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 0705e51 to f240fa7 Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 50ef8b9 to 0de5bd4 Compare May 27, 2022 22:39
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from f240fa7 to f1b5d11 Compare May 27, 2022 22:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 0de5bd4 to 2905a20 Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from f1b5d11 to f07fa98 Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 2905a20 to 9452b16 Compare May 27, 2022 23:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from f07fa98 to d99025e Compare May 27, 2022 23:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 9452b16 to 09f7811 Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from d99025e to 045f80f Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 09f7811 to 69e7245 Compare May 28, 2022 01:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 045f80f to debd5a1 Compare May 28, 2022 01:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 69e7245 to 1c5f626 Compare May 28, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from debd5a1 to d3e1ad6 Compare May 28, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 1c5f626 to 2dfd5c5 Compare May 31, 2022 23:17
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from d3e1ad6 to b831698 Compare May 31, 2022 23:17
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 2dfd5c5 to 5e8470d Compare June 1, 2022 00:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from b831698 to f1a9556 Compare June 1, 2022 00:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 5e8470d to e623be1 Compare June 10, 2022 03:32
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from f1a9556 to 57e532e Compare June 10, 2022 03:32
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from e623be1 to 5fe3c6b Compare July 26, 2022 22:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 57e532e to 7acd423 Compare July 26, 2022 22:13
@jakebailey jakebailey changed the title CONVERSION STEP - stripNamespaces CONVERSION STEP - explicitify Jul 26, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-3 branch from 5fe3c6b to bf6c8d6 Compare July 26, 2022 23:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-4 branch from 7acd423 to 1601465 Compare July 26, 2022 23:06
@jakebailey
Generated module conversion step - explicitify
dc25bdf 
This step makes all implicit namespace accesses explicit, e.g. "Node" turns into "ts.Node".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey