Skip to content

Remove outFiles from launch.json#42

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-34from
transform-stack-commit-35
Closed

Remove outFiles from launch.json#42
jakebailey wants to merge 1 commit into
transform-stack-commit-34from
transform-stack-commit-35

Conversation

@jakebailey

@jakebailey jakebailey commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

The troubleshooting wizard for the debugger actually says that this
option is no longer recommended; removing it enables us to use source
maps if we happen to be debugging while in --bundle=false mode.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json (this PR)
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from cd6575e to c1c022f Compare October 10, 2022 21:05
@jakebailey jakebailey changed the title Remove mkdirp Switch to faster XML parsing library for localize Oct 10, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 5a34d8d to c7de568 Compare October 10, 2022 21:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from c1c022f to 89c70f6 Compare October 10, 2022 22:54
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from c7de568 to ffc6ec7 Compare October 10, 2022 22:54
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 89c70f6 to b941749 Compare October 10, 2022 23:14
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from ffc6ec7 to 3969a14 Compare October 10, 2022 23:14
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from b941749 to c9f38a8 Compare October 10, 2022 23:31
@jakebailey jakebailey changed the title Switch to faster XML parsing library for localize Modernize localize script Oct 10, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 3969a14 to da4179f Compare October 10, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from c9f38a8 to d822193 Compare October 11, 2022 23:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from da4179f to 9096423 Compare October 11, 2022 23:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from d822193 to d4ecd69 Compare October 11, 2022 23:32
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 9096423 to 8016f34 Compare October 11, 2022 23:32
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from d4ecd69 to bf75805 Compare October 12, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 8016f34 to c82877a Compare October 12, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from bf75805 to 1d9a16b Compare October 14, 2022 19:36
@jakebailey jakebailey changed the title Modernize localize script Switch to faster XML parsing library for localize Oct 14, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from c82877a to 21bb51f Compare October 14, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 1d9a16b to 6f8306c Compare October 14, 2022 21:21
@jakebailey jakebailey changed the title Switch to faster XML parsing library for localize Don't use needsUpdate for quick tasks Oct 14, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 21bb51f to 76abc2c Compare October 14, 2022 21:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 6f8306c to ab40f1f Compare October 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 76abc2c to d5045ae Compare October 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from ab40f1f to 30f5ad0 Compare October 14, 2022 23:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from d5045ae to 82a6121 Compare October 14, 2022 23:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 30f5ad0 to 6189add Compare October 20, 2022 00:50
@jakebailey jakebailey changed the title Don't use needsUpdate for quick tasks Specify rootDir and outDir in tsconfig-base rather than in each tsconfig Oct 20, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 82a6121 to 3382b8e Compare October 20, 2022 00:50
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 6189add to bb0f23b Compare October 20, 2022 01:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from ef3b6a0 to 72b92d6 Compare October 23, 2022 00:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 28cdd63 to 484c771 Compare October 24, 2022 04:38
@jakebailey jakebailey changed the title Compute esbuild options lazily Remove globalThisShim and globalThis modification for TypeScriptServicesFactory Oct 24, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 72b92d6 to c02560b Compare October 24, 2022 04:39
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 484c771 to 3e074aa Compare October 24, 2022 18:10
@jakebailey jakebailey changed the title Remove globalThisShim and globalThis modification for TypeScriptServicesFactory Disable slow CodeQL queries Oct 24, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from c02560b to 49f1987 Compare October 24, 2022 18:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 3e074aa to e67ae6f Compare October 24, 2022 20:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 49f1987 to 0a85be7 Compare October 24, 2022 20:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch 3 times, most recently from 97e5600 to 764336a Compare October 27, 2022 17:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 0a85be7 to 51779c7 Compare October 27, 2022 17:48
@jakebailey jakebailey changed the title Disable slow CodeQL queries Remove outFiles from launch.json Oct 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 764336a to 129c982 Compare October 28, 2022 02:30
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 51779c7 to 4d427a0 Compare October 28, 2022 02:30
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 129c982 to 94f969d Compare October 31, 2022 21:41
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 4d427a0 to e5a97fd Compare October 31, 2022 21:41
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 94f969d to 0bc2246 Compare November 2, 2022 00:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from e5a97fd to 4759e29 Compare November 2, 2022 00:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 0bc2246 to 6a0fa73 Compare November 2, 2022 17:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 4759e29 to 49ec27c Compare November 2, 2022 17:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 6a0fa73 to 5b807ff Compare November 2, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 49ec27c to 2c343d1 Compare November 2, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 5b807ff to 672cbe3 Compare November 6, 2022 21:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 2c343d1 to 6ec9b22 Compare November 6, 2022 21:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 672cbe3 to 5b1ebbb Compare November 6, 2022 21:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-35 branch from 6ec9b22 to dbe3815 Compare November 6, 2022 21:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-34 branch from 5b1ebbb to b0cf7dc Compare November 7, 2022 03:54
@jakebailey
Remove outFiles from launch.json
4eab497 
The troubleshooting wizard for the debugger actually says that this
option is no longer recommended; removing it enables us to use source
maps if we happen to be debugging while in --bundle=false mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey