Convert require calls to imports#15
Closed
jakebailey wants to merge 1 commit into
Closed
Conversation
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 16:52
739e71d to
a31b0ef
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 16:52
d60d508 to
a3b3d68
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 20:27
a31b0ef to
223a3f5
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 20:27
a3b3d68 to
4f53563
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:02
223a3f5 to
9b79d42
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 21:02
4f53563 to
3a93e7a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:47
9b79d42 to
72d390c
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 21:47
3a93e7a to
abad547
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:58
72d390c to
ff637c0
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 21:58
abad547 to
fca4bc0
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 23:22
ff637c0 to
40f3f72
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 13, 2022 23:22
fca4bc0 to
6fac93a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 14, 2022 17:26
40f3f72 to
d4005a7
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 14, 2022 17:26
6fac93a to
1993fa1
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:35
d4005a7 to
c80e914
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 16, 2022 04:35
1993fa1 to
286195b
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:37
c80e914 to
1764185
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 16, 2022 04:37
286195b to
b740f77
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 05:43
1764185 to
ebf0539
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 16, 2022 05:43
b740f77 to
ea26c2f
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:11
ebf0539 to
22a440a
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 19, 2022 20:11
ea26c2f to
e08154d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:38
22a440a to
e744bbc
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 19, 2022 20:38
e08154d to
aece916
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:06
e744bbc to
0d8842b
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 20, 2022 05:06
aece916 to
fc8b8a7
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:10
0d8842b to
99362b4
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 20, 2022 05:10
fc8b8a7 to
7190b1f
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 00:44
e900d70 to
8756a16
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 28, 2022 00:45
d01dece to
e9b9554
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 05:04
8756a16 to
7d2ba94
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 28, 2022 05:04
e9b9554 to
4a7339c
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 07:45
7d2ba94 to
521087f
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 28, 2022 07:45
4a7339c to
2d1e68d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 19:39
521087f to
3b3a4fb
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 28, 2022 19:39
2d1e68d to
a0f30c3
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 28, 2022 22:03
3b3a4fb to
473bb4d
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
September 28, 2022 22:03
a0f30c3 to
b19d9ec
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 3, 2022 21:40
473bb4d to
e59a783
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 3, 2022 21:40
b19d9ec to
0bdaade
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 3, 2022 23:33
e59a783 to
34301ab
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 3, 2022 23:33
0bdaade to
871d511
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 17:58
34301ab to
c36c875
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 17:59
871d511 to
0064923
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 19:05
c36c875 to
5fd5dca
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 19:06
0064923 to
d51757d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 19:52
5fd5dca to
56e74d3
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 19:52
d51757d to
f17d929
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 21:01
56e74d3 to
f604298
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 21:01
f17d929 to
992373d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 22:18
f604298 to
517eee8
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 22:18
992373d to
d5b78d1
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 22:48
517eee8 to
f54e048
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 22:48
d5b78d1 to
c76a144
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 4, 2022 23:13
f54e048 to
c58c1e4
Compare
jakebailey
force-pushed
the
transform-stack-commit-14
branch
from
October 4, 2022 23:13
c76a144 to
2423766
Compare
Although the existing require calls would work fine, it's more consistent to make them actual imports and let them be converted at compile/bundle time. It also lets us emit ESM if needed. There are still conditional requires present for things like the node System, but that's a more difficult problem to solve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the existing require calls would work fine, it's more
consistent to make them actual imports and let them be converted at
compile/bundle time. It also lets us emit ESM if needed.
There are still conditional requires present for things like the node
System, but that's a more difficult problem to solve.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: