Skip to content

Remove mkdirp#29

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-26from
transform-stack-commit-27
Closed

Remove mkdirp#29
jakebailey wants to merge 1 commit into
transform-stack-commit-26from
transform-stack-commit-27

Conversation

@jakebailey

@jakebailey jakebailey commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

If our build scripts target Node 10+, we can use the builtin mkdir
function in recursive mode instead.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp (this PR)
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from e9316dd to 1c70182 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from ce3b98c to 1d92ee1 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 1c70182 to 25cb26a Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Convert __require back to require for external bundlers Add ts to globalThis for convenience during debugging Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 1d92ee1 to e5d5826 Compare October 4, 2022 17:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 25cb26a to 96f3991 Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Add ts to globalThis for convenience during debugging Remove ref files from testRunner Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from e5d5826 to cdac21e Compare October 4, 2022 19:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 96f3991 to 9576473 Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from cdac21e to 1ecfbcf Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 9576473 to 4849168 Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Remove ref files from testRunner Restore self-compilation using built compiler in CI tests Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 1ecfbcf to a038a66 Compare October 4, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 4849168 to 12bafe1 Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from a038a66 to a764e7e Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 12bafe1 to 7094ca0 Compare October 6, 2022 18:36
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Temporarily disable template literals Oct 6, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from a764e7e to 28ddc46 Compare October 6, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 7094ca0 to 2349bc4 Compare October 7, 2022 18:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 28ddc46 to c71f45d Compare October 7, 2022 18:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch 2 times, most recently from f5ed806 to fca9261 Compare October 7, 2022 19:31
@jakebailey jakebailey changed the title Temporarily disable template literals Add a --bundle=false variant to CI Oct 7, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from c71f45d to a2e8cb7 Compare October 7, 2022 19:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from fca9261 to 83dcbc3 Compare October 7, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from a2e8cb7 to 7b1db7c Compare October 7, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 83dcbc3 to 70f88a7 Compare October 7, 2022 22:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 7b1db7c to ff36738 Compare October 7, 2022 22:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 70f88a7 to 16ff6b8 Compare October 9, 2022 00:42
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from ff36738 to 61928b0 Compare October 9, 2022 00:42
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 90dec08 to 4689e28 Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 589841a to 1d4d97d Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 4689e28 to c0e9528 Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 1d4d97d to d9a9adc Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from c0e9528 to 88eacf5 Compare October 12, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from d9a9adc to 6ab119e Compare October 12, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 88eacf5 to c16a98b Compare October 14, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 6ab119e to 733c0e6 Compare October 14, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from c16a98b to 6319e44 Compare October 14, 2022 21:20
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 733c0e6 to ba8a59b Compare October 14, 2022 21:20
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 6319e44 to 6c706b6 Compare October 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from ba8a59b to d7e5973 Compare October 14, 2022 22:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 6c706b6 to c73759b Compare October 14, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from d7e5973 to 52c081d Compare October 14, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from c73759b to d0842df Compare October 20, 2022 00:50
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Use jsonc-parser instead of LKG compiler in build Oct 20, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 52c081d to bcf178a Compare October 20, 2022 00:50
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from d0842df to 260c592 Compare October 20, 2022 01:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from bcf178a to d69deef Compare October 20, 2022 01:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 260c592 to 105a757 Compare October 20, 2022 20:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from d69deef to 25a1259 Compare October 20, 2022 20:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 105a757 to b525788 Compare October 20, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 25a1259 to 773c785 Compare October 20, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from b525788 to 14c02e2 Compare October 21, 2022 23:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 773c785 to 569d38b Compare October 21, 2022 23:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from 14c02e2 to e09e943 Compare October 22, 2022 16:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from 569d38b to e1610cf Compare October 22, 2022 16:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-26 branch from e09e943 to c75fb9d Compare October 23, 2022 00:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-27 branch from e1610cf to a591754 Compare October 23, 2022 00:11
@jakebailey
Remove mkdirp
37d74bb 
If our build scripts target Node 10+, we can use the builtin mkdir
function in recursive mode instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey