Skip to content

Update baselines for corrected line endings in lib files#25

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-22from
transform-stack-commit-23
Closed

Update baselines for corrected line endings in lib files#25
jakebailey wants to merge 1 commit into
transform-stack-commit-22from
transform-stack-commit-23

Conversation

@jakebailey

@jakebailey jakebailey commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

The old gulpfile produced lib.d.ts files with mixed newlines, thanks to
the files containing CRLF, but the gulp streams adding in LF.

Now they're all LF, which matches every other file in built / lib, but
our baselines are sensitive to this. Rerun the tests and accept them.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files (this PR)
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from d375574 to 459e8a7 Compare September 28, 2022 07:46
@jakebailey jakebailey changed the title Fix APISample tests to not depend on the existence of the ts namespace Remove generation of protocol.d.ts Sep 28, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from ea93e92 to ee472f3 Compare September 28, 2022 07:46
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 459e8a7 to a7df000 Compare September 28, 2022 19:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from ee472f3 to 6dac7c1 Compare September 28, 2022 19:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from a7df000 to ffd5699 Compare September 28, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 6dac7c1 to edb57ce Compare September 28, 2022 22:04
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from ffd5699 to 7cb5a91 Compare October 3, 2022 21:41
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from edb57ce to b0cf9f5 Compare October 3, 2022 21:41
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 7cb5a91 to 4ada7a6 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from b0cf9f5 to 119e8e2 Compare October 3, 2022 23:34
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 4ada7a6 to 16238e3 Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Remove generation of protocol.d.ts Ensure all projects are listed in root tsconfig.json Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 119e8e2 to b51bb17 Compare October 4, 2022 17:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 16238e3 to ca1ee4b Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Ensure all projects are listed in root tsconfig.json Add dts bundling Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from b51bb17 to b71a1dd Compare October 4, 2022 19:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from ca1ee4b to 948cdee Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from b71a1dd to 64c42a5 Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 948cdee to 7fed31f Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Add dts bundling Ensure all projects are listed in root tsconfig.json Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 64c42a5 to b77418d Compare October 4, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 7fed31f to eba9674 Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from b77418d to a02e266 Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from eba9674 to 2b5bb22 Compare October 4, 2022 22:49
@jakebailey jakebailey changed the title Ensure all projects are listed in root tsconfig.json Update baselines Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from a02e266 to 03c218e Compare October 4, 2022 22:49
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 2b5bb22 to 743892c Compare October 4, 2022 23:14
@jakebailey jakebailey changed the title Update baselines Consolidate checks that test if the current environment is Node Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 03c218e to 4a86b4c Compare October 4, 2022 23:14
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Consolidate checks that test if the current environment is Node Oct 7, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 9c4d4fa to c40a9e5 Compare October 7, 2022 19:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from d4f94e0 to d2a31b1 Compare October 7, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from c40a9e5 to 2abc5d0 Compare October 7, 2022 19:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from d2a31b1 to f7af961 Compare October 7, 2022 22:05
@jakebailey jakebailey changed the title Consolidate checks that test if the current environment is Node Add dts bundling Oct 7, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 2abc5d0 to 3b39d43 Compare October 7, 2022 22:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from f7af961 to 52978c8 Compare October 9, 2022 00:42
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 3b39d43 to 0ac4856 Compare October 9, 2022 00:42
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 52978c8 to d466f4f Compare October 10, 2022 17:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 0ac4856 to 1aa9c01 Compare October 10, 2022 17:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from d466f4f to a5ae9f0 Compare October 10, 2022 21:04
@jakebailey jakebailey changed the title Add dts bundling Add build via esbuild Oct 10, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 1aa9c01 to 708c6b0 Compare October 10, 2022 21:05
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from a5ae9f0 to fc6dc01 Compare October 10, 2022 22:54
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 708c6b0 to d0d0647 Compare October 10, 2022 22:54
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from fc6dc01 to 02b74ed Compare October 10, 2022 23:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from d0d0647 to eeb0587 Compare October 10, 2022 23:13
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 02b74ed to 2adec9e Compare October 10, 2022 23:30
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from eeb0587 to df6bfd9 Compare October 10, 2022 23:30
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 2adec9e to 84c2eb0 Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from df6bfd9 to 6e05f0d Compare October 11, 2022 23:15
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 84c2eb0 to 76a6eea Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from 6e05f0d to ebadd3e Compare October 11, 2022 23:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 76a6eea to 1079abc Compare October 12, 2022 22:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from ebadd3e to b589ea0 Compare October 12, 2022 22:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-22 branch from 1079abc to 3291b34 Compare October 14, 2022 19:35
@jakebailey jakebailey changed the title Add build via esbuild Add dts bundling Oct 14, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-23 branch from b589ea0 to db1ce42 Compare October 14, 2022 19:35
@jakebailey
Update baselines for corrected line endings in lib files
b520f09 
The old gulpfile produced lib.d.ts files with mixed newlines, thanks to
the files containing CRLF, but the gulp streams adding in LF.

Now they're all LF, which matches every other file in built / lib, but
our baselines are sensitive to this. Rerun the tests and accept them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey