Add ts to globalThis in run.js for convenience during debugging#22
Closed
jakebailey wants to merge 1 commit into
Closed
Add ts to globalThis in run.js for convenience during debugging#22jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
jakebailey
force-pushed
the
transform-stack-commit-19
branch
3 times, most recently
from
September 20, 2022 05:06
1a97904 to
c388116
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 20, 2022 05:06
e666aad to
a88fedb
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
3 times, most recently
from
September 24, 2022 16:51
c292ea6 to
bb4001f
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 24, 2022 16:51
a88fedb to
0b39eda
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 26, 2022 23:10
bb4001f to
5813ec9
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 26, 2022 23:10
0b39eda to
472b33b
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 27, 2022 21:59
5813ec9 to
58f41e1
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 27, 2022 21:59
472b33b to
41cda7d
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 00:37
58f41e1 to
eac528e
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 00:37
41cda7d to
bde0986
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 00:45
eac528e to
04898d5
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 00:45
bde0986 to
3ee116d
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 05:04
04898d5 to
6726b3b
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 05:04
3ee116d to
3065851
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 07:46
6726b3b to
e57029d
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 07:46
3065851 to
9f09312
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 19:40
e57029d to
75162a2
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 19:40
9f09312 to
7eb1f08
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
September 28, 2022 22:03
75162a2 to
01112ec
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
September 28, 2022 22:03
7eb1f08 to
d46fefa
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 3, 2022 21:41
01112ec to
d4decce
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 3, 2022 21:41
d46fefa to
074ba8f
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 3, 2022 23:33
d4decce to
d29dbf6
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 3, 2022 23:34
074ba8f to
4d20fcf
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 4, 2022 22:19
28d648a to
aa74194
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 4, 2022 22:48
aba928d to
9a815ba
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 4, 2022 22:49
aa74194 to
98fd58c
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 4, 2022 23:13
9a815ba to
eb15662
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 4, 2022 23:14
98fd58c to
f588ed7
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 4, 2022 23:35
eb15662 to
5474498
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 4, 2022 23:35
f588ed7 to
7e108ce
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 6, 2022 18:35
5474498 to
a31f4a9
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 6, 2022 18:35
7e108ce to
798841e
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 7, 2022 18:34
a31f4a9 to
a3b59da
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 7, 2022 18:34
798841e to
468c3e5
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 7, 2022 19:03
a3b59da to
6acb704
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 7, 2022 19:03
468c3e5 to
19b5908
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 7, 2022 19:30
6acb704 to
47edef3
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 7, 2022 19:30
19b5908 to
9de9f71
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 7, 2022 19:36
47edef3 to
ae445e7
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 7, 2022 19:36
9de9f71 to
5319496
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 7, 2022 22:05
ae445e7 to
fd4e37c
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 7, 2022 22:05
5319496 to
8990762
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 9, 2022 00:41
fd4e37c to
a311ce1
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 9, 2022 00:41
8990762 to
8724e29
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 10, 2022 17:09
a311ce1 to
ad2830f
Compare
jakebailey
force-pushed
the
transform-stack-commit-20
branch
from
October 10, 2022 17:09
8724e29 to
66fd901
Compare
jakebailey
force-pushed
the
transform-stack-commit-19
branch
from
October 10, 2022 21:04
ad2830f to
e711fb2
Compare
In namespaces, we'd have access to a variable named "ts" when debugging, because that was just the ts namespace in the current file. But when modules, that variable doesn't exist, either because we are pure modules (so no ts variable), or named something else (when bundled, for export). Tack a "ts" object onto the globals, which should make this easier. Of course, someone may eventually declare a variable in the top level scope named "ts" and break this, but we can cross that bridge when we come to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In namespaces, we'd have access to a variable named "ts" when debugging,
because that was just the ts namespace in the current file. But when
modules, that variable doesn't exist, either because we are pure modules
(so no ts variable), or named something else (when bundled, for export).
Tack a "ts" object onto the globals, which should make this easier. Of
course, someone may eventually declare a variable in the top level scope
named "ts" and break this, but we can cross that bridge when we come to
it.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: