Ensure ts object passed to plugins contains deprecatedCompat declarations#32
Closed
jakebailey wants to merge 1 commit into
Closed
Ensure ts object passed to plugins contains deprecatedCompat declarations#32jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 3, 2022 23:34
6f93bd7 to
638ebf8
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 3, 2022 23:34
8d70519 to
79f21b3
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
5 times, most recently
from
October 10, 2022 17:10
68929dd to
5d22fdb
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 17:10
79f21b3 to
ce2b59b
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 10, 2022 21:05
5d22fdb to
a520d61
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
2 times, most recently
from
October 10, 2022 22:54
b124ac1 to
435ba70
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 10, 2022 23:14
5844106 to
2977b78
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 23:14
435ba70 to
49047e7
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 10, 2022 23:31
2977b78 to
a10c176
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 23:31
49047e7 to
a96025d
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 11, 2022 23:15
a10c176 to
6b92337
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 11, 2022 23:15
a96025d to
26681a1
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 11, 2022 23:31
6b92337 to
b0404d2
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 11, 2022 23:31
26681a1 to
535e94d
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 12, 2022 22:48
b0404d2 to
42bf9b2
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 12, 2022 22:48
535e94d to
b0f7ebf
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 14, 2022 19:36
42bf9b2 to
10e0ca6
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 19:36
b0f7ebf to
9a8a98e
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 14, 2022 21:20
10e0ca6 to
dd46066
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 21:20
9a8a98e to
c08a758
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 14, 2022 22:28
dd46066 to
c702b8a
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 22:28
c08a758 to
3e53449
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 20, 2022 22:03
b709f96 to
32c4699
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 21, 2022 23:25
3cd03b4 to
30d33b4
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 21, 2022 23:26
32c4699 to
b893480
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 22, 2022 16:59
30d33b4 to
bd9148a
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 22, 2022 16:59
b893480 to
485210a
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 23, 2022 00:11
bd9148a to
aeb3907
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 23, 2022 00:11
485210a to
c9712e2
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 24, 2022 04:38
aeb3907 to
943a958
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 04:38
c9712e2 to
5334e71
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 24, 2022 18:10
943a958 to
8ae43ee
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 18:10
5334e71 to
cb2ccfd
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 24, 2022 20:33
8ae43ee to
e349e38
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 20:33
cb2ccfd to
f9f8e9e
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 24, 2022 23:15
e349e38 to
6a282bf
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 23:15
f9f8e9e to
a7d2107
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 25, 2022 02:24
6a282bf to
3d30fcf
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 25, 2022 02:25
a7d2107 to
1f616d1
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 27, 2022 17:46
3d30fcf to
00984a4
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 27, 2022 17:46
1f616d1 to
393d0de
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 28, 2022 02:28
00984a4 to
f9a1913
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 28, 2022 02:28
393d0de to
540a735
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
October 31, 2022 21:39
f9a1913 to
f2b4185
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 31, 2022 21:39
540a735 to
abb36fd
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
November 2, 2022 00:49
f2b4185 to
f9a2bfc
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 2, 2022 00:50
abb36fd to
9f30548
Compare
jakebailey
force-pushed
the
transform-stack-commit-29
branch
from
November 2, 2022 17:01
f9a2bfc to
1c3f00f
Compare
…ions We pass the entire "ts" object into plugins. However, we need to make sure that that object contains the debug compat helpers. In the old codebase, the deprecated compat code would tack things onto the actual ts object, after the server code was executed, and later that same object would be given to plugins. But in modules, each TS project only sees the view of the "ts" namespace that their references implied, not the ts object as some sort of singleton. To ensure that plugins get the debug compat code, we have to bring that into each project's view of the ts namespace, and not add it on later in the executable projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We pass the entire "ts" object into plugins. However, we need to make
sure that that object contains the debug compat helpers.
In the old codebase, the deprecated compat code would tack things onto
the actual ts object, after the server code was executed, and later that
same object would be given to plugins.
But in modules, each TS project only sees the view of the "ts" namespace
that their references implied, not the ts object as some sort of
singleton. To ensure that plugins get the debug compat code, we have to
bring that into each project's view of the ts namespace, and not add it
on later in the executable projects.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: