Skip to content

Generated module conversion step - inlineImports#6

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-5from
transform-stack-commit-6
Closed

Generated module conversion step - inlineImports#6
jakebailey wants to merge 1 commit into
transform-stack-commit-5from
transform-stack-commit-6

Conversation

@jakebailey

@jakebailey jakebailey commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports (this PR)
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 329f521 to 2313137 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [5/8] Make processDiagnosticMessages generate a module [6/8] Make processDiagnosticMessages generate a module May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 247c864 to 242d1c6 Compare May 27, 2022 04:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 2313137 to 7d283a7 Compare May 27, 2022 04:23
@jakebailey jakebailey changed the title [6/8] Make processDiagnosticMessages generate a module Make processDiagnosticMessages generate a module May 27, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 242d1c6 to c18fa64 Compare May 27, 2022 04:23
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 7d283a7 to 3a0814e Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from c18fa64 to c28a0b1 Compare May 27, 2022 18:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 3a0814e to 9a87f02 Compare May 27, 2022 18:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from c28a0b1 to 79541db Compare May 27, 2022 18:24
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 9a87f02 to cd17d62 Compare May 27, 2022 18:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 79541db to 2e6ace5 Compare May 27, 2022 18:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from cd17d62 to 77acbad Compare May 27, 2022 18:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 2e6ace5 to 3b71964 Compare May 27, 2022 18:35
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 77acbad to 6eaa4d7 Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 3b71964 to 44341e4 Compare May 27, 2022 18:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 6eaa4d7 to 85db2a2 Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 44341e4 to 134a2c7 Compare May 27, 2022 21:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 85db2a2 to 5825466 Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 134a2c7 to cd2e1dd Compare May 27, 2022 22:25
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 5825466 to 0b8b75d Compare May 27, 2022 22:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from cd2e1dd to 865fab5 Compare May 27, 2022 22:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 0b8b75d to ca0e93f Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 865fab5 to d6d8c40 Compare May 27, 2022 23:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from ca0e93f to 449c9cf Compare May 27, 2022 23:56
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from d6d8c40 to b74523a Compare May 27, 2022 23:57
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 449c9cf to 3069f69 Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from b74523a to 2298837 Compare May 28, 2022 00:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 3069f69 to 4a7abaa Compare May 28, 2022 01:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 2298837 to 92fa215 Compare May 28, 2022 01:52
@jakebailey jakebailey changed the title Make processDiagnosticMessages generate a module CONVERSION STEP - inlineImports Jul 26, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from f02cf9a to 3d628b5 Compare July 26, 2022 23:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 88176b1 to 85481c6 Compare August 24, 2022 23:46
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 3d628b5 to 64b75da Compare August 24, 2022 23:46
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 85481c6 to beadbb5 Compare August 25, 2022 19:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 64b75da to 0973fa3 Compare August 25, 2022 19:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from beadbb5 to 3134381 Compare August 25, 2022 22:55
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 0973fa3 to f3766ee Compare August 25, 2022 22:55
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 3134381 to ac66b63 Compare August 26, 2022 20:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from f3766ee to b598438 Compare August 26, 2022 20:09
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from ac66b63 to 8e0d7d7 Compare August 29, 2022 23:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from b598438 to 65344d6 Compare August 29, 2022 23:16
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 8e0d7d7 to 3139192 Compare August 31, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 65344d6 to 7298d5d Compare August 31, 2022 21:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 3139192 to 6690649 Compare September 3, 2022 04:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 7298d5d to 685c8f4 Compare September 3, 2022 04:21
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 6690649 to 0a656ba Compare September 3, 2022 04:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 685c8f4 to 69f5297 Compare September 3, 2022 04:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 0a656ba to 0a9a102 Compare September 7, 2022 22:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 69f5297 to 456b986 Compare September 7, 2022 22:31
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 0a9a102 to f463aba Compare September 13, 2022 16:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 456b986 to 949b0ec Compare September 13, 2022 16:51
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from f463aba to 3a193e5 Compare September 13, 2022 20:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from 949b0ec to ca526e7 Compare September 13, 2022 20:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 3a193e5 to 2a26179 Compare September 13, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from ca526e7 to ce1af6d Compare September 13, 2022 21:02
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 2a26179 to 8f84110 Compare September 13, 2022 21:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-6 branch from ce1af6d to e3150b9 Compare September 13, 2022 21:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-5 branch from 8f84110 to f7c19b6 Compare September 13, 2022 21:57
@jakebailey
Generated module conversion step - inlineImports
d762022 
This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey