Skip to content

Get codebase building pre bundling#17

Closed
jakebailey wants to merge 1 commit into
transform-stack-commit-15from
transform-stack-commit-16
Closed

Get codebase building pre bundling#17
jakebailey wants to merge 1 commit into
transform-stack-commit-15from
transform-stack-commit-16

Conversation

@jakebailey

@jakebailey jakebailey commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

This isn't totally complete, but enough to get everything building and
tests running manually. The next commit will make the build work fully.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling (this PR)
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 5360203 to 2ac243c Compare September 13, 2022 16:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 4776832 to 0b8b109 Compare September 13, 2022 16:52
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 2ac243c to 70d9433 Compare September 13, 2022 20:27
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 0b8b109 to 9890b10 Compare September 13, 2022 20:28
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 70d9433 to 928ab66 Compare September 13, 2022 21:03
@jakebailey jakebailey changed the title Hand convert non-JSDoc at-internal comments Fix all internal JSDoc comments Sep 13, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 9890b10 to d768606 Compare September 13, 2022 21:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 928ab66 to 867a2aa Compare September 13, 2022 21:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from d768606 to cf88621 Compare September 13, 2022 21:47
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 867a2aa to 1254f1a Compare September 13, 2022 21:58
@jakebailey jakebailey changed the title Fix all internal JSDoc comments Ensure emitted d.ts files do not contain extraneous import expressions Sep 13, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from cf88621 to b4dd985 Compare September 13, 2022 21:58
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 1254f1a to 97aa3be Compare September 13, 2022 23:22
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from b4dd985 to 594728a Compare September 13, 2022 23:22
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 97aa3be to d668e08 Compare September 14, 2022 17:26
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 594728a to f07182a Compare September 14, 2022 17:26
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from d668e08 to 28e85d5 Compare September 16, 2022 04:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from f07182a to 8187c8b Compare September 16, 2022 04:36
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 28e85d5 to 71704b8 Compare September 16, 2022 04:37
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 8187c8b to dd3c92a Compare September 16, 2022 04:37
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 71704b8 to ee9fbc7 Compare September 16, 2022 05:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from dd3c92a to a64011e Compare September 16, 2022 05:43
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from ee9fbc7 to b8eeb40 Compare September 19, 2022 20:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from a64011e to 72bcb7d Compare September 19, 2022 20:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from b8eeb40 to 1e25093 Compare September 19, 2022 20:38
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 72bcb7d to 6db765e Compare September 19, 2022 20:38
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 1e25093 to bf0399d Compare September 20, 2022 05:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 6db765e to 89a75d5 Compare September 20, 2022 05:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from bf0399d to f226b70 Compare September 20, 2022 05:10
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 89a75d5 to 8ce2c5c Compare September 20, 2022 05:11
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from a4698ae to b4e9ca3 Compare September 28, 2022 00:37
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from c2b0a91 to b95e405 Compare September 28, 2022 00:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from b4e9ca3 to 5a3e12d Compare September 28, 2022 00:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from b95e405 to 75582e7 Compare September 28, 2022 05:04
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 5a3e12d to 1ada148 Compare September 28, 2022 05:04
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 75582e7 to 2152cf2 Compare September 28, 2022 07:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 1ada148 to 0383453 Compare September 28, 2022 07:45
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 2152cf2 to f6780bd Compare September 28, 2022 19:39
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 0383453 to 1c1e869 Compare September 28, 2022 19:39
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from f6780bd to 3f7e479 Compare September 28, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 1c1e869 to ca27000 Compare September 28, 2022 22:03
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 3f7e479 to 45c3c48 Compare October 3, 2022 21:40
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from ca27000 to d1c6ff3 Compare October 3, 2022 21:41
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 45c3c48 to 66ca26d Compare October 3, 2022 23:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from d1c6ff3 to 09f26b7 Compare October 3, 2022 23:33
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 66ca26d to 2e8feb7 Compare October 4, 2022 17:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 09f26b7 to f54f1db Compare October 4, 2022 17:59
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 2e8feb7 to 764c0f4 Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Get entrypoints working Get test suites running Oct 4, 2022
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from f54f1db to 7772ed6 Compare October 4, 2022 19:06
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 764c0f4 to 282525d Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 7772ed6 to 0e45ca3 Compare October 4, 2022 19:53
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from 282525d to fb22af2 Compare October 4, 2022 21:01
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from 0e45ca3 to c194d53 Compare October 4, 2022 21:01
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from fb22af2 to bc169e6 Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from c194d53 to c792af7 Compare October 4, 2022 22:19
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from bc169e6 to a1ebbc5 Compare October 4, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-16 branch from c792af7 to 9d444ee Compare October 4, 2022 22:48
@jakebailey
jakebailey force-pushed the transform-stack-commit-15 branch from a1ebbc5 to dc2c1b9 Compare October 4, 2022 23:13
@jakebailey
Get codebase building pre bundling
248fbdc 
This isn't totally complete, but enough to get everything building and
tests running manually. The next commit will make the build work fully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey